fix(web): polish sidebar v2 chrome and composer surfaces#4252
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
github-actions
Bot
added
vouch:trusted
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using high effort and found 3 potential issues.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit c384406. Configure here.
| )} | ||
| </span> | ||
| )) | ||
| )} |
There was a problem hiding this comment.
Slim rows hide thread time
Medium Severity
On settled slim sidebar rows, the right-hand slot renders either the PR badge or the relative time, not both. Threads with an open PR no longer show when they were last active, which makes scanning settled history harder than before this layout change.
Reviewed by Cursor Bugbot for commit c384406. Configure here.
| tooltip={{ | ||
| children: newThreadShortcutLabel | ||
| ? `New thread (${newThreadShortcutLabel})` | ||
| : "New thread", |
There was a problem hiding this comment.
New thread shortcut hint wrong
Low Severity
The new-thread control only resolves a keyboard hint when isElectron is true and only for chat.new, while the adjacent Search control still shows its binding on web. Sidebar v1 falls back to chat.newLocal and does not gate the label on Electron, so tooltips can omit or misstate the shortcut users actually have bound.
Reviewed by Cursor Bugbot for commit c384406. Configure here.
| )} | ||
| </span> | ||
| )) | ||
| )} |
There was a problem hiding this comment.
PR badge hidden on hover
Medium Severity
On settled slim sidebar rows, the PR # control is rendered inside the trailing slot that gets group-hover/v2-row:opacity-0 so the settle/unsettle affordance can appear. Hovering the row hides the PR badge, so users cannot reliably open the PR from the sidebar history list.
Reviewed by Cursor Bugbot for commit c384406. Configure here.
ApprovabilityVerdict: Needs human review UI polish changes to sidebar and composer styling. However, three unresolved review comments identify potential bugs: PR badge hidden on hover, thread time hidden when PR badge shown, and incorrect shortcut hints on non-Electron. These usability regressions warrant human review before merging. You can customize Macroscope's approvability policy. Learn more. |
… marker Maria's design pass lands as-is: scoped graphite sidebar palette, rounded composer shell, simplified project chrome, lighter card and filter styling. Her removal of the composer project chip supersedes ours (same outcome). One addition on top: the settled boundary gets its quiet label back. Her pass replaced the SETTLED mono-caps divider with a bare 8px gap — but an unnamed gap doesn't explain why rows below it look different, and the name anchors what un-settle/settle act on. Restored minimally in her visual language: a 10px muted 'Settled' word with a soft hairline, no mono, no caps, no tracking. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
23a72f5
into
pingdotgg:t3code/new-sidebar-client-only
|
Merged into #4026 (the sidebar v2 beta PR) — thank you, this pass is lovely. One addition on top: the settled boundary got its label back in your visual language — a quiet 10px muted "Settled" word with a soft hairline instead of the old mono-caps divider — so the tail reads as a named zone rather than an unexplained gap. |
2 participants
What Changed
Why
These changes are UI-only follow-ups on top of #4026. They tighten the visual hierarchy in Sidebar v2, make the composer and sidebar feel like part of the same surface system, and remove some extra chrome around project identity that was pulling focus away from the thread content.
UI Changes
Checklist
Validation
vp run --filter @t3tools/web typecheckvp test run apps/web/src/components/Sidebar.logic.test.ts apps/web/src/components/chat/ChatHeader.test.tsNote
Cursor Bugbot is generating a summary for commit c384406. Configure here.
Note
Polish Sidebar V2 chrome and composer surfaces with new color palette and status UI
.app-sidebarCSS class and theme tokens in index.css.SidebarV2Rowreplaces edge strips and status word badges with icon-based status labels ('Working', 'Approval', 'Input', 'Failed', 'Done'), adds unread awareness to visually de-emphasize ready/read threads, and removes per-second timer ticking.compactSidebarTimeLabelhelper in SidebarV2.tsx.Macroscope summarized c384406.