Skip to content

Install react query v4 and add auth context#5893

Merged
khanhtc1202 merged 1 commit into
masterfrom
install_react-query
Jun 26, 2025
Merged

Install react query v4 and add auth context#5893
khanhtc1202 merged 1 commit into
masterfrom
install_react-query

Conversation

@hongky-1994
Copy link
Copy Markdown
Contributor

@hongky-1994 hongky-1994 commented May 28, 2025

What this PR does:

  • Install react query v4
  • Add Auth Context
  • Remove redux module/me

Why we need it:

  • AuthContext to replace module/me in redux storage.
  • We use react query v4 instead of v5 due to dependency conflict. React-Query v5 only support react 18+, whereas v4 is support for react 16.8+ which is more suitable for our current setting (react 17).

Which issue(s) this PR fixes:

Partof #5868

Does this PR introduce a user-facing change?: no

  • How are users affected by this change: no
  • Is this breaking change: no
  • How to migrate (if breaking change): no

@hongky-1994 hongky-1994 requested review from a team as code owners May 28, 2025 16:34
@github-actions
Copy link
Copy Markdown
Contributor

@hongky-1994
Thank you for your contribution! We look forward to seeing more from you.
Please run the make check command to ensure your changes will pass the CI.
After successfully running the command on your local machine, the instructions will be printed out.
Please follow them to commit your changes.
If the check has not passed, please fix the issues and push the changes to your branch.
Then, please run the make check command again to ensure the issues are fixed.

@codecov
Copy link
Copy Markdown

codecov Bot commented May 28, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 28.15%. Comparing base (aaed1ad) to head (92367a3).
Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5893   +/-   ##
=======================================
  Coverage   28.15%   28.15%           
=======================================
  Files         518      518           
  Lines       55909    55909           
=======================================
  Hits        15743    15743           
  Misses      38914    38914           
  Partials     1252     1252           
Flag Coverage Δ
. 23.22% <ø> (ø)
.-pkg-app-pipedv1-plugin-example 0.00% <ø> (ø)
.-pkg-app-pipedv1-plugin-kubernetes 66.42% <ø> (ø)
.-pkg-app-pipedv1-plugin-kubernetes_multicluster 67.51% <ø> (ø)
.-pkg-app-pipedv1-plugin-wait 35.51% <ø> (ø)
.-pkg-plugin-sdk 50.89% <ø> (ø)
.-tool-actions-gh-release 19.23% <ø> (ø)
.-tool-actions-plan-preview 25.30% <ø> (ø)
.-tool-codegen-protoc-gen-auth 0.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Copy Markdown
Member

@t-kikuc t-kikuc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Migrated from me to contexts/, I got it.

@Warashi
Copy link
Copy Markdown
Member

Warashi commented May 29, 2025

Sorry, we updated the CI and branch protection rules.
I updated the branch of this PR by pushing the Update branch button, which is the GitHub feature.
Please let me know if you see any unexpected behavior.

@hongky-1994 hongky-1994 force-pushed the install_react-query branch 2 times, most recently from 852e236 to ec35706 Compare June 10, 2025 17:16
@hongky-1994 hongky-1994 force-pushed the install_react-query branch from ec35706 to 800c38f Compare June 16, 2025 17:51
@hongky-1994 hongky-1994 force-pushed the install_react-query branch from 800c38f to e8d72bf Compare June 26, 2025 07:56
Signed-off-by: kypham <hongkyhvnh@gmail.com>
@hongky-1994 hongky-1994 force-pushed the install_react-query branch from e8d72bf to 92367a3 Compare June 26, 2025 08:04
Copy link
Copy Markdown
Member

@Warashi Warashi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
I checked that this works on my local.

@khanhtc1202 khanhtc1202 merged commit fdb9066 into master Jun 26, 2025
40 checks passed
@khanhtc1202 khanhtc1202 deleted the install_react-query branch June 26, 2025 09:00
@github-actions github-actions Bot mentioned this pull request Jul 14, 2025
@github-actions github-actions Bot mentioned this pull request Aug 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants