Remove Redux in Insight page#5915
Merged
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5915 +/- ##
=======================================
Coverage 28.16% 28.16%
=======================================
Files 516 516
Lines 55895 55895
=======================================
Hits 15743 15743
Misses 38900 38900
Partials 1252 1252
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
hongky-1994
changed the title
This was referenced May 29, 2025
hongky-1994
force-pushed
the
redux-replace-insight-page
branch
2 times, most recently
from
eaa460f to
33bf7e8
Compare
hongky-1994
force-pushed
the
redux-replace-insight-page
branch
from
33bf7e8 to
e1bb2a3
Compare
hongky-1994
force-pushed
the
redux-replace-insight-page
branch
from
e1bb2a3 to
a635bc6
Compare
- remove module insight - remove module deployment-change-failure-rate - remove module deployment-frequency - add query for insight - add query for app list , piped list - add toast messages context - update query provider with error handler show toast Signed-off-by: kypham <hongkyhvnh@gmail.com>
hongky-1994
force-pushed
the
redux-replace-insight-page
branch
from
a635bc6 to
dfc1e0d
Compare
Member
|
@hongky-1994 1. Applications by piped show the different values for the two cases below. Is this related to the fix in this PR?
2. On my local check, I found the icon like the image below. Is it for development mode? When clicking the icon, we can see something like the image below. |
Signed-off-by: kypham <hongkyhvnh@gmail.com>
Contributor
Author
|
Thanks @ffjlabo
|
Member
|
@hongky-1994 Thank you for checking, LGTM! |
ffjlabo
approved these changes
Jun 30, 2025
Member
|
@khanhtc1202 Sorry, plz re-approve |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does:
Why we need it:
Which issue(s) this PR fixes:
Partof #5868
Does this PR introduce a user-facing change?: