Skip to content

Redux replace setting api keys page#5933

Merged
t-kikuc merged 1 commit into
masterfrom
redux-replace-setting-api-keys
Jul 18, 2025
Merged

Redux replace setting api keys page#5933
t-kikuc merged 1 commit into
masterfrom
redux-replace-setting-api-keys

Conversation

@hongky-1994
Copy link
Copy Markdown
Contributor

What this PR does:

  • This MR depends on Redux replace events page #5928
  • remove redux modules/api-keys
  • add query hook for get api keys
  • add mutation hook for generate key, disabled key
  • Update test

Why we need it:

  • remove redux module from settings/api-keys page

Which issue(s) this PR fixes:

Partof #5868

Does this PR introduce a user-facing change?: no

  • How are users affected by this change: no
  • Is this breaking change: no
  • How to migrate (if breaking change): no

@codecov
Copy link
Copy Markdown

codecov Bot commented Jun 9, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 28.28%. Comparing base (c16abf8) to head (8a259aa).
Report is 8 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5933   +/-   ##
=======================================
  Coverage   28.28%   28.28%           
=======================================
  Files         523      523           
  Lines       56135    56135           
=======================================
+ Hits        15875    15879    +4     
+ Misses      39008    39005    -3     
+ Partials     1252     1251    -1     
Flag Coverage Δ
. 23.27% <ø> (ø)
.-pkg-app-pipedv1-plugin-kubernetes 65.94% <ø> (ø)
.-pkg-app-pipedv1-plugin-kubernetes_multicluster 67.33% <ø> (ø)
.-pkg-app-pipedv1-plugin-scriptrun 66.66% <ø> (ø)
.-pkg-app-pipedv1-plugin-terraform 80.26% <ø> (ø)
.-pkg-app-pipedv1-plugin-wait 35.51% <ø> (ø)
.-pkg-plugin-sdk 50.71% <ø> (+0.20%) ⬆️
.-tool-actions-gh-release 19.23% <ø> (ø)
.-tool-actions-plan-preview 25.30% <ø> (ø)
.-tool-codegen-protoc-gen-auth 0.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@hongky-1994 hongky-1994 force-pushed the redux-replace-setting-api-keys branch from 25206f4 to 1bacefe Compare June 10, 2025 17:23
@hongky-1994 hongky-1994 force-pushed the redux-replace-setting-api-keys branch from 1bacefe to cbcfb1a Compare June 16, 2025 17:54
@hongky-1994 hongky-1994 force-pushed the redux-replace-setting-api-keys branch 3 times, most recently from fa08856 to 0d8c526 Compare July 3, 2025 16:44
- Remove modules/api-keys
- Add query for api-keys
- Update test case for ApiKeyPage

Signed-off-by: kypham <hongkyhvnh@gmail.com>
@hongky-1994 hongky-1994 force-pushed the redux-replace-setting-api-keys branch from 0d8c526 to 8a259aa Compare July 14, 2025 04:31
@hongky-1994 hongky-1994 marked this pull request as ready for review July 14, 2025 04:33
@hongky-1994 hongky-1994 requested review from a team as code owners July 14, 2025 04:33
Copy link
Copy Markdown
Member

@khanhtc1202 khanhtc1202 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍

@khanhtc1202
Copy link
Copy Markdown
Member

Confirmed the behaviour as same as current on dev env 👀

@t-kikuc t-kikuc merged commit 28fceb8 into master Jul 18, 2025
42 checks passed
@t-kikuc t-kikuc deleted the redux-replace-setting-api-keys branch July 18, 2025 11:20
@github-actions github-actions Bot mentioned this pull request Aug 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants