Skip to content

Redux replace events page#5928

Merged
ffjlabo merged 1 commit into
masterfrom
redux-replace-events-page
Jul 14, 2025
Merged

Redux replace events page#5928
ffjlabo merged 1 commit into
masterfrom
redux-replace-events-page

Conversation

@hongky-1994
Copy link
Copy Markdown
Contributor

@hongky-1994 hongky-1994 commented Jun 9, 2025

What this PR does:

Why we need it:

  • remove redux module from event page

Which issue(s) this PR fixes:

Partof #5868

Does this PR introduce a user-facing change?: no

  • How are users affected by this change: no
  • Is this breaking change: no
  • How to migrate (if breaking change): no

@codecov
Copy link
Copy Markdown

codecov Bot commented Jun 9, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 28.20%. Comparing base (69ce763) to head (5f25fb6).
Report is 11 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5928      +/-   ##
==========================================
- Coverage   28.21%   28.20%   -0.02%     
==========================================
  Files         520      520              
  Lines       56046    56046              
==========================================
- Hits        15814    15808       -6     
- Misses      38980    38986       +6     
  Partials     1252     1252              
Flag Coverage Δ
. 23.21% <ø> (-0.02%) ⬇️
.-pkg-app-pipedv1-plugin-kubernetes 66.44% <ø> (ø)
.-pkg-app-pipedv1-plugin-kubernetes_multicluster 67.33% <ø> (ø)
.-pkg-app-pipedv1-plugin-terraform 80.26% <ø> (ø)
.-pkg-app-pipedv1-plugin-wait 35.51% <ø> (ø)
.-pkg-plugin-sdk 50.71% <ø> (ø)
.-tool-actions-gh-release 19.23% <ø> (ø)
.-tool-actions-plan-preview 25.30% <ø> (ø)
.-tool-codegen-protoc-gen-auth 0.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@hongky-1994 hongky-1994 force-pushed the redux-replace-events-page branch from 75fd780 to 676865d Compare June 9, 2025 03:16
@hongky-1994 hongky-1994 force-pushed the redux-replace-events-page branch 2 times, most recently from 41d1b58 to d80d22d Compare June 16, 2025 17:53
@hongky-1994 hongky-1994 force-pushed the redux-replace-events-page branch 2 times, most recently from ea97ab4 to eb747c6 Compare June 30, 2025 02:08
@hongky-1994 hongky-1994 marked this pull request as ready for review June 30, 2025 02:20
@hongky-1994 hongky-1994 requested review from a team as code owners June 30, 2025 02:20
@hongky-1994 hongky-1994 force-pushed the redux-replace-events-page branch 6 times, most recently from 13e3db6 to 504b63d Compare July 7, 2025 10:10
@ffjlabo
Copy link
Copy Markdown
Member

ffjlabo commented Jul 8, 2025

@hongky-1994
I found that the difference in behavior between the demo.pipecd.dev, and this fix.
Filtering events by status appears to reset the state.
Could you check it?

  1. On the demo.pipecd.dev
2025-07-08.10.28.44.mov
  1. On this fix
2025-07-08.10.33.02.mov

Signed-off-by: kypham <hongkyhvnh@gmail.com>
@hongky-1994 hongky-1994 force-pushed the redux-replace-events-page branch from 504b63d to 5f25fb6 Compare July 9, 2025 07:06
@hongky-1994
Copy link
Copy Markdown
Contributor Author

Thanks @ffjlabo ,
I have update the code to keep the minUpdatedAt like the demo.pipe.dev . Please review it again . Thank you so much.

CleanShot.2025-07-09.at.10.58.50.mp4

Copy link
Copy Markdown
Member

@ffjlabo ffjlabo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! LGTM!

Copy link
Copy Markdown
Member

@khanhtc1202 khanhtc1202 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@ffjlabo ffjlabo merged commit b5e37b7 into master Jul 14, 2025
39 of 40 checks passed
@ffjlabo ffjlabo deleted the redux-replace-events-page branch July 14, 2025 02:01
@github-actions github-actions Bot mentioned this pull request Jul 14, 2025
@github-actions github-actions Bot mentioned this pull request Aug 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants