[Plugin] Remove plugin name from the arg when calling sdk.NewPlugin#5935
Merged
Conversation
ffjlabo
changed the title
sdk.NewPlugin
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5935 +/- ##
==========================================
- Coverage 28.48% 28.47% -0.02%
==========================================
Files 520 520
Lines 56416 56416
==========================================
- Hits 16070 16064 -6
- Misses 39080 39086 +6
Partials 1266 1266
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ffjlabo
force-pushed
the
update-sdk-verson
branch
from
e77011a to
073f3aa
Compare
t-kikuc
reviewed
Jun 11, 2025
| return nil, fmt.Errorf("failed to prepare plugin %s config: %w", pCfg.Name, err) | ||
| } | ||
| args = append(args, "--config", string(b)) | ||
| args = append(args, "--name", pCfg.Name) |
Member
There was a problem hiding this comment.
It might be better to git pull origin master??
I guess this diff will be removed.
Signed-off-by: Yoshiki Fujikane <ffjlabo@gmail.com>
Signed-off-by: Yoshiki Fujikane <ffjlabo@gmail.com>
ffjlabo
force-pushed
the
update-sdk-verson
branch
from
f45557e to
55cbac0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does:
as title
Why we need it:
We need to support
--nameoption for each plugin to pipedv1 start them from #5931.Which issue(s) this PR fixes:
Follow #5931
Does this PR introduce a user-facing change?: