Pass plugin name from Piped to plugin#5931
Merged
Merged
Conversation
Signed-off-by: t-kikuc <tkikuchi07f@gmail.com>
t-kikuc
commented
Jun 9, 2025
| // Run runs the plugin. | ||
| func (p *Plugin[Config, DeployTargetConfig, ApplicationConfigSpec]) Run() error { | ||
| app := cli.NewApp( | ||
| fmt.Sprintf("pipecd-plugin-%s", p.name), |
Member
Author
There was a problem hiding this comment.
This name is not important. And p.name is empty when showing this message.
t-kikuc
commented
Jun 9, 2025
| func (p *Plugin[Config, DeployTargetConfig, ApplicationConfigSpec]) command() *cobra.Command { | ||
| cmd := &cobra.Command{ | ||
| Use: "start", | ||
| Short: fmt.Sprintf("Start running a %s plugin.", p.name), |
Member
Author
There was a problem hiding this comment.
This name is not important. And p.name is empty when showing this message.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5931 +/- ##
==========================================
- Coverage 28.46% 28.46% -0.01%
==========================================
Files 520 520
Lines 56416 56419 +3
==========================================
Hits 16061 16061
- Misses 39089 39092 +3
Partials 1266 1266
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does:
namearg fromsdk.NewPlugin()After merging this PR, we need to update the plugins.
Why we need it:
nameis confusing for plugin developerspipecd/pkg/plugin/sdk/deployment_source.go
Lines 42 to 51 in 8dbe938
Which issue(s) this PR fixes:
Part of #5530
Does this PR introduce a user-facing change?:
This is a breaking change of the SDK. Not a user-facing change.