Use PipedPlugin.Name instead of passing --name in the SDK#5936
Merged
Conversation
Signed-off-by: t-kikuc <tkikuchi07f@gmail.com>
t-kikuc
commented
Jun 11, 2025
| // When this happens, it means that there is a bug in the SDK, because these are private fields. | ||
| input.Logger.Error( | ||
| "something went wrong in the SDK, please report this issue to the developers", | ||
| zap.String("name", p.name), |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5936 +/- ##
=======================================
Coverage 28.48% 28.48%
=======================================
Files 520 520
Lines 56421 56416 -5
=======================================
Hits 16070 16070
+ Misses 39085 39080 -5
Partials 1266 1266
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
t-kikuc
changed the title
t-kikuc
changed the title
ffjlabo
approved these changes
Jun 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does:
as title
Why we need it:
--nameis not necessary.This PR is simpler than #5931
Which issue(s) this PR fixes:
Follows #5931
Does this PR introduce a user-facing change?: