Skip to content

Get only livestate-supported plugin clients when flushing the livestate#5940

Closed
ffjlabo wants to merge 4 commits into
masterfrom
check-livestate-supported
Closed

Get only livestate-supported plugin clients when flushing the livestate#5940
ffjlabo wants to merge 4 commits into
masterfrom
check-livestate-supported

Conversation

@ffjlabo
Copy link
Copy Markdown
Member

@ffjlabo ffjlabo commented Jun 11, 2025

What this PR does:

This is the fix for pluginRegistry's logic.

  • Fixed to check whether the plugin server supports LivestateService in advance, by using gRPC reflection.
  • Get only livestate-supported plugin clients when flushing the livestate.

Why we need it:

Currently, the livestate reporter fails to report when there are some plugins that don't support the livestate feature. (e.g. wait stage).

Livestate reporter calls GetLivestate for each plugin when flushing an app.
But currently, it fails when one of them has an error, including an unimplemented status.

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

  • How are users affected by this change:
  • Is this breaking change:
  • How to migrate (if breaking change):

ffjlabo added 2 commits June 11, 2025 16:49
Signed-off-by: Yoshiki Fujikane <ffjlabo@gmail.com>
Signed-off-by: Yoshiki Fujikane <ffjlabo@gmail.com>
@codecov
Copy link
Copy Markdown

codecov Bot commented Jun 11, 2025

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 54.94%. Comparing base (d73300d) to head (2f8aca5).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
pkg/plugin/sdk/plugin.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           master    #5940       +/-   ##
===========================================
+ Coverage   28.47%   54.94%   +26.46%     
===========================================
  Files         520       86      -434     
  Lines       56415     8538    -47877     
===========================================
- Hits        16063     4691    -11372     
+ Misses      39086     3525    -35561     
+ Partials     1266      322      -944     
Flag Coverage Δ
. ?
.-pkg-app-pipedv1-plugin-example 0.00% <ø> (ø)
.-pkg-app-pipedv1-plugin-kubernetes 66.42% <ø> (ø)
.-pkg-app-pipedv1-plugin-kubernetes_multicluster 67.51% <ø> (ø)
.-pkg-app-pipedv1-plugin-wait 35.51% <ø> (ø)
.-pkg-plugin-sdk 49.20% <0.00%> (-0.03%) ⬇️
.-tool-actions-gh-release 19.23% <ø> (ø)
.-tool-actions-plan-preview 25.30% <ø> (ø)
.-tool-codegen-protoc-gen-auth 0.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ffjlabo ffjlabo changed the title Check livestate supported Get only livestate-supported plugin clients when flushing the livestate Jun 11, 2025
Signed-off-by: Yoshiki Fujikane <ffjlabo@gmail.com>
@ffjlabo ffjlabo marked this pull request as ready for review June 11, 2025 08:41
@ffjlabo ffjlabo requested a review from a team as a code owner June 11, 2025 08:41
Signed-off-by: Yoshiki Fujikane <ffjlabo@gmail.com>
@ffjlabo
Copy link
Copy Markdown
Member Author

ffjlabo commented Jun 12, 2025

I found the simple alternative way. So close this PR.

@ffjlabo ffjlabo closed this Jun 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant