Skip to content

Ignore unsupported plugin when reporting livestate#5942

Merged
ffjlabo merged 2 commits into
masterfrom
ignore-unsupported-plugin-when-reporting-livestate
Jun 12, 2025
Merged

Ignore unsupported plugin when reporting livestate#5942
ffjlabo merged 2 commits into
masterfrom
ignore-unsupported-plugin-when-reporting-livestate

Conversation

@ffjlabo
Copy link
Copy Markdown
Member

@ffjlabo ffjlabo commented Jun 12, 2025

What this PR does:

Get only livestate-supported plugin clients when flushing the livestate.

Currently, the livestate reporter fails to report when there are some plugins that don't support the livestate feature. (e.g. wait stage).

Livestate reporter calls GetLivestate for each plugin when flushing an app.
But currently, it fails when one of them has an error, including an unimplemented status.

Why we need it:

Which issue(s) this PR fixes:

Follow #5940
Part of #5363

Does this PR introduce a user-facing change?:

  • How are users affected by this change:
  • Is this breaking change:
  • How to migrate (if breaking change):

Signed-off-by: Yoshiki Fujikane <ffjlabo@gmail.com>
@codecov
Copy link
Copy Markdown

codecov Bot commented Jun 12, 2025

Codecov Report

Attention: Patch coverage is 50.00000% with 5 lines in your changes missing coverage. Please review.

Project coverage is 28.47%. Comparing base (d73300d) to head (ab14df5).
Report is 4 commits behind head on master.

Files with missing lines Patch % Lines
...app/pipedv1/livestatereporter/livestatereporter.go 0.00% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5942      +/-   ##
==========================================
- Coverage   28.47%   28.47%   -0.01%     
==========================================
  Files         520      520              
  Lines       56415    56410       -5     
==========================================
- Hits        16063    16060       -3     
+ Misses      39086    39084       -2     
  Partials     1266     1266              
Flag Coverage Δ
. 23.76% <50.00%> (+0.01%) ⬆️
.-pkg-app-pipedv1-plugin-example 0.00% <ø> (ø)
.-pkg-app-pipedv1-plugin-kubernetes 66.42% <ø> (ø)
.-pkg-app-pipedv1-plugin-kubernetes_multicluster 67.51% <ø> (ø)
.-pkg-app-pipedv1-plugin-wait 35.51% <ø> (ø)
.-pkg-plugin-sdk 48.86% <ø> (-0.37%) ⬇️
.-tool-actions-gh-release 19.23% <ø> (ø)
.-tool-actions-plan-preview 25.30% <ø> (ø)
.-tool-codegen-protoc-gen-auth 0.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Signed-off-by: Yoshiki Fujikane <ffjlabo@gmail.com>
@ffjlabo ffjlabo force-pushed the ignore-unsupported-plugin-when-reporting-livestate branch from 7b6aac8 to ab14df5 Compare June 12, 2025 01:27
@ffjlabo ffjlabo marked this pull request as ready for review June 12, 2025 01:35
@ffjlabo ffjlabo requested a review from a team as a code owner June 12, 2025 01:35
Copy link
Copy Markdown
Member

@t-kikuc t-kikuc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

When livestatereporter has performance issues, let's improve.

// TODO: show plugin name
r.logger.Info("plugin does not support livestate feature")
continue
}
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When needed in the future (not now),
let's remove such plugins from pluginClis, err := r.pluginRegistry.GetPluginClientsByAppConfig(cfg.Spec) by like r.pluginRegistry.markPluginAsLiveStateUnsupported(xxx) to reduce unnecessary gRPC calls.

Copy link
Copy Markdown
Member

@Warashi Warashi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

@ffjlabo ffjlabo merged commit d522ec4 into master Jun 12, 2025
40 checks passed
@ffjlabo ffjlabo deleted the ignore-unsupported-plugin-when-reporting-livestate branch June 12, 2025 02:32
@github-actions github-actions Bot mentioned this pull request Jul 14, 2025
@github-actions github-actions Bot mentioned this pull request Aug 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants