Skip to content

Add --match opion for git describe for build/chart#5949

Merged
ffjlabo merged 1 commit into
masterfrom
add-match-option
Jun 13, 2025
Merged

Add --match opion for git describe for build/chart#5949
ffjlabo merged 1 commit into
masterfrom
add-match-option

Conversation

@ffjlabo
Copy link
Copy Markdown
Member

@ffjlabo ffjlabo commented Jun 13, 2025

What this PR does:

as title

Why we need it:

When creating the tag whose format is not semantic version, build/chart fails because helm chart supports only semantic versioning.
So we decided to allow only semantic versioned one.

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

  • How are users affected by this change:
  • Is this breaking change:
  • How to migrate (if breaking change):

Signed-off-by: Yoshiki Fujikane <ffjlabo@gmail.com>
@ffjlabo ffjlabo requested a review from a team as a code owner June 13, 2025 05:48
@ffjlabo ffjlabo changed the title Add --match opion for git describe Add --match opion for git describe for build/chart Jun 13, 2025
Copy link
Copy Markdown
Member

@Warashi Warashi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

@codecov
Copy link
Copy Markdown

codecov Bot commented Jun 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 28.49%. Comparing base (19aed96) to head (aa72648).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5949   +/-   ##
=======================================
  Coverage   28.49%   28.49%           
=======================================
  Files         520      520           
  Lines       56436    56436           
=======================================
  Hits        16082    16082           
  Misses      39087    39087           
  Partials     1267     1267           
Flag Coverage Δ
. 23.80% <ø> (ø)
.-pkg-app-pipedv1-plugin-example 0.00% <ø> (ø)
.-pkg-app-pipedv1-plugin-kubernetes 66.41% <ø> (ø)
.-pkg-app-pipedv1-plugin-kubernetes_multicluster 67.50% <ø> (ø)
.-pkg-app-pipedv1-plugin-wait 35.51% <ø> (ø)
.-pkg-plugin-sdk 48.86% <ø> (ø)
.-tool-actions-gh-release 19.23% <ø> (ø)
.-tool-actions-plan-preview 25.30% <ø> (ø)
.-tool-codegen-protoc-gen-auth 0.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Copy Markdown
Member

@t-kikuc t-kikuc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!!!

@ffjlabo ffjlabo enabled auto-merge (squash) June 13, 2025 05:50
@ffjlabo ffjlabo merged commit 6854617 into master Jun 13, 2025
40 checks passed
@ffjlabo ffjlabo deleted the add-match-option branch June 13, 2025 05:53
@github-actions github-actions Bot mentioned this pull request Jul 14, 2025
@github-actions github-actions Bot mentioned this pull request Aug 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants