Skip to content

Fix retrieving recent tag from git log#6059

Merged
Warashi merged 1 commit into
masterfrom
fix-build-go-tag-retrieve
Jul 23, 2025
Merged

Fix retrieving recent tag from git log#6059
Warashi merged 1 commit into
masterfrom
fix-build-go-tag-retrieve

Conversation

@Warashi
Copy link
Copy Markdown
Member

@Warashi Warashi commented Jul 23, 2025

What this PR does:

This PR fixes tag retrieving logic in the Makefile

Why we need it:

To avoid getting the kubecon special tag.

Which issue(s) this PR fixes:

Follows #5949 #5953

Does this PR introduce a user-facing change?:

  • How are users affected by this change:
  • Is this breaking change:
  • How to migrate (if breaking change):

Signed-off-by: Shinnosuke Sawada-Dazai <shin@warashi.dev>
@Warashi Warashi requested a review from a team as a code owner July 23, 2025 07:59
@codecov
Copy link
Copy Markdown

codecov Bot commented Jul 23, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 28.28%. Comparing base (5e723a8) to head (172d0a2).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #6059   +/-   ##
=======================================
  Coverage   28.28%   28.28%           
=======================================
  Files         521      521           
  Lines       56099    56099           
=======================================
  Hits        15868    15868           
  Misses      38982    38982           
  Partials     1249     1249           
Flag Coverage Δ
. 23.18% <ø> (ø)
.-pkg-app-pipedv1-plugin-kubernetes 65.94% <ø> (ø)
.-pkg-app-pipedv1-plugin-kubernetes_multicluster 67.33% <ø> (ø)
.-pkg-app-pipedv1-plugin-scriptrun 66.66% <ø> (ø)
.-pkg-app-pipedv1-plugin-terraform 38.11% <ø> (ø)
.-pkg-app-pipedv1-plugin-wait 35.51% <ø> (ø)
.-pkg-plugin-sdk 52.03% <ø> (ø)
.-tool-actions-gh-release 19.23% <ø> (ø)
.-tool-actions-plan-preview 25.30% <ø> (ø)
.-tool-codegen-protoc-gen-auth 0.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Copy Markdown
Member

@t-kikuc t-kikuc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!

@Warashi Warashi enabled auto-merge (squash) July 23, 2025 08:12
Copy link
Copy Markdown
Member

@khanhtc1202 khanhtc1202 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍

@Warashi Warashi merged commit dbb48b4 into master Jul 23, 2025
42 checks passed
@Warashi Warashi deleted the fix-build-go-tag-retrieve branch July 23, 2025 08:19
hongky-1994 pushed a commit that referenced this pull request Jul 30, 2025
Signed-off-by: Shinnosuke Sawada-Dazai <shin@warashi.dev>
@github-actions github-actions Bot mentioned this pull request Aug 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants