Remove pipelineStage.ID config#5964
Merged
Merged
Conversation
Signed-off-by: khanhtc1202 <khanhtc1202@gmail.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5964 +/- ##
=======================================
Coverage 28.16% 28.16%
=======================================
Files 518 518
Lines 55916 55917 +1
=======================================
+ Hits 15748 15749 +1
Misses 38916 38916
Partials 1252 1252
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: khanhtc1202 <khanhtc1202@gmail.com>
Signed-off-by: khanhtc1202 <khanhtc1202@gmail.com>
t-kikuc
approved these changes
Jun 24, 2025
ffjlabo
approved these changes
Jun 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does:
Remove pipelineStage.ID from application config.
Why we need it:
This field is used as the ID for logic, such as the key in metadatastore, logger name, etc. So we should not allow it to be set by users. This PR removes the pipelineStage.ID config, thus users will not be able to set it for pipedv1. All pipelineStage.ID creation will be handled by piped on the planning step
Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?: