Skip to content

Remove pipelineStage.ID config#5964

Merged
khanhtc1202 merged 3 commits into
masterfrom
remove-pipelinestage-id-config
Jun 24, 2025
Merged

Remove pipelineStage.ID config#5964
khanhtc1202 merged 3 commits into
masterfrom
remove-pipelinestage-id-config

Conversation

@khanhtc1202
Copy link
Copy Markdown
Member

@khanhtc1202 khanhtc1202 commented Jun 24, 2025

What this PR does:

Remove pipelineStage.ID from application config.

Why we need it:

This field is used as the ID for logic, such as the key in metadatastore, logger name, etc. So we should not allow it to be set by users. This PR removes the pipelineStage.ID config, thus users will not be able to set it for pipedv1. All pipelineStage.ID creation will be handled by piped on the planning step

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

  • How are users affected by this change:
  • Is this breaking change:
  • How to migrate (if breaking change):

Signed-off-by: khanhtc1202 <khanhtc1202@gmail.com>
@codecov
Copy link
Copy Markdown

codecov Bot commented Jun 24, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 28.16%. Comparing base (8a12400) to head (abe2a67).
Report is 4 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5964   +/-   ##
=======================================
  Coverage   28.16%   28.16%           
=======================================
  Files         518      518           
  Lines       55916    55917    +1     
=======================================
+ Hits        15748    15749    +1     
  Misses      38916    38916           
  Partials     1252     1252           
Flag Coverage Δ
. 23.22% <100.00%> (+<0.01%) ⬆️
.-pkg-app-pipedv1-plugin-example 0.00% <ø> (ø)
.-pkg-app-pipedv1-plugin-kubernetes 66.42% <ø> (ø)
.-pkg-app-pipedv1-plugin-kubernetes_multicluster 67.51% <ø> (ø)
.-pkg-app-pipedv1-plugin-wait 35.51% <ø> (ø)
.-pkg-plugin-sdk 50.97% <ø> (ø)
.-tool-actions-gh-release 19.23% <ø> (ø)
.-tool-actions-plan-preview 25.30% <ø> (ø)
.-tool-codegen-protoc-gen-auth 0.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Signed-off-by: khanhtc1202 <khanhtc1202@gmail.com>
Signed-off-by: khanhtc1202 <khanhtc1202@gmail.com>
@khanhtc1202 khanhtc1202 enabled auto-merge (squash) June 24, 2025 09:44
@khanhtc1202 khanhtc1202 merged commit a9f1fb7 into master Jun 24, 2025
40 checks passed
@khanhtc1202 khanhtc1202 deleted the remove-pipelinestage-id-config branch June 24, 2025 09:48
@github-actions github-actions Bot mentioned this pull request Jul 14, 2025
@github-actions github-actions Bot mentioned this pull request Aug 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants