Skip to content

Remove pipelineStage.ID config #5964

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
khanhtc1202 merged 3 commits into from
Jun 24, 2025
Merged

Remove pipelineStage.ID config #5964

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3f2e6a4
Remove pipelineStage.ID config
khanhtc1202 Jun 24, 2025
4e0b0e8
Update comment explain the quick sync plan build logic
khanhtc1202 Jun 24, 2025
abe2a67
Fix failed tests
khanhtc1202 Jun 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions pkg/app/pipedv1/controller/planner.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@ import (
"sort"
"time"

"github.com/google/uuid"
"go.opentelemetry.io/otel/attribute"
"go.opentelemetry.io/otel/trace"
"go.uber.org/atomic"
Expand Down Expand Up @@ -414,8 +415,7 @@ func (p *planner) buildPlan(ctx context.Context, runningDS, targetDS *common.Dep
// buildQuickSyncStages requests all plugins and returns quick sync stage
// from each plugins to build the deployment pipeline.
// NOTE:
// - For quick sync, we expect all stages given by plugins can be performed
// at once regradless its order (aka. no `Stage.Requires` specified)
// - For quick sync, we expect all stages given by plugins can be performed in random order.
// - Rollback stage will always be added as the trail.
func (p *planner) buildQuickSyncStages(ctx context.Context, cfg *config.GenericApplicationSpec) ([]*model.PipelineStage, error) {
var (
Expand All @@ -436,6 +436,7 @@ func (p *planner) buildQuickSyncStages(ctx context.Context, cfg *config.GenericA
return nil, err
}
for i := range res.Stages {
res.Stages[i].Id = uuid.New().String()
if res.Stages[i].Rollback {
rollbackStages = append(rollbackStages, res.Stages[i])
} else {
Expand Down Expand Up @@ -478,7 +479,6 @@ func (p *planner) buildPipelineSyncStages(ctx context.Context, cfg *config.Gener
}

stagesCfgPerPlugin[plg] = append(stagesCfgPerPlugin[plg], &deployment.BuildPipelineSyncStagesRequest_StageConfig{
Id: stageCfg.ID,
Name: stageCfg.Name.String(),
Desc: stageCfg.Desc,
Timeout: stageCfg.Timeout.Duration().String(),
Expand All @@ -503,6 +503,7 @@ func (p *planner) buildPipelineSyncStages(ctx context.Context, cfg *config.Gener
}

for i := range res.Stages {
res.Stages[i].Id = uuid.New().String()
if res.Stages[i].Rollback {
rollbackStages = append(rollbackStages, res.Stages[i])
} else {
Expand Down
Loading