Pass ApplicationConfigFiilename when creating deploysource.DeploySource#5987
Conversation
Signed-off-by: Shinnosuke Sawada-Dazai <shin@warashi.dev>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5987 +/- ##
==========================================
+ Coverage 28.16% 28.17% +0.01%
==========================================
Files 516 516
Lines 55895 55897 +2
==========================================
+ Hits 15743 15751 +8
+ Misses 38900 38894 -6
Partials 1252 1252
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
t-kikuc
left a comment
There was a problem hiding this comment.
[ASK] Where is ApplicationConfigFiilename used?
|
@t-kikuc pipecd/pkg/app/pipedv1/plugin/kubernetes/provider/loader.go Lines 212 to 214 in 73b52db |
|
@Warashi Thank you, I got it. |
What this PR does:
as title
Why we need it:
We have to pass it because plugins need this.
Which issue(s) this PR fixes:
Part of #4980
Does this PR introduce a user-facing change?: