Skip to content

Pass ApplicationConfigFiilename when creating deploysource.DeploySource#5987

Merged
Warashi merged 1 commit into
masterfrom
pipedv1-pass-app-config-filename
Jul 4, 2025
Merged

Pass ApplicationConfigFiilename when creating deploysource.DeploySource#5987
Warashi merged 1 commit into
masterfrom
pipedv1-pass-app-config-filename

Conversation

@Warashi
Copy link
Copy Markdown
Member

@Warashi Warashi commented Jul 2, 2025

What this PR does:

as title

Why we need it:

We have to pass it because plugins need this.

Which issue(s) this PR fixes:

Part of #4980

Does this PR introduce a user-facing change?:

  • How are users affected by this change:
  • Is this breaking change:
  • How to migrate (if breaking change):

Signed-off-by: Shinnosuke Sawada-Dazai <shin@warashi.dev>
@Warashi Warashi requested a review from a team as a code owner July 2, 2025 05:00
@Warashi Warashi enabled auto-merge (squash) July 2, 2025 05:00
@codecov
Copy link
Copy Markdown

codecov Bot commented Jul 2, 2025

Codecov Report

Attention: Patch coverage is 0% with 10 lines in your changes missing coverage. Please review.

Project coverage is 28.17%. Comparing base (fdb9066) to head (5cb4414).
Report is 19 commits behind head on master.

Files with missing lines Patch % Lines
pkg/app/pipedv1/deploysource/deploysource.go 0.00% 10 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5987      +/-   ##
==========================================
+ Coverage   28.16%   28.17%   +0.01%     
==========================================
  Files         516      516              
  Lines       55895    55897       +2     
==========================================
+ Hits        15743    15751       +8     
+ Misses      38900    38894       -6     
  Partials     1252     1252              
Flag Coverage Δ
. 23.23% <0.00%> (+0.01%) ⬆️
.-pkg-app-pipedv1-plugin-kubernetes 66.42% <ø> (ø)
.-pkg-app-pipedv1-plugin-kubernetes_multicluster 67.51% <ø> (ø)
.-pkg-app-pipedv1-plugin-wait 35.51% <ø> (ø)
.-pkg-plugin-sdk 50.89% <ø> (ø)
.-tool-actions-gh-release 19.23% <ø> (ø)
.-tool-actions-plan-preview 25.30% <ø> (ø)
.-tool-codegen-protoc-gen-auth 0.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Copy Markdown
Member

@t-kikuc t-kikuc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[ASK] Where is ApplicationConfigFiilename used?

@Warashi
Copy link
Copy Markdown
Member Author

Warashi commented Jul 2, 2025

@t-kikuc
In the Kubernetes plugin, we use ApplicationConfigFiilename to avoid loading app.pipecd.yaml as a Kubernetes manifest.
The configFilename in the below line comes from ApplicationConfigFiilename.

if d.Name() == configFilename {
return nil
}

@t-kikuc
Copy link
Copy Markdown
Member

t-kikuc commented Jul 2, 2025

@Warashi Thank you, I got it.

Copy link
Copy Markdown
Member

@ffjlabo ffjlabo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Warashi Warashi merged commit 8d9d755 into master Jul 4, 2025
37 of 38 checks passed
@Warashi Warashi deleted the pipedv1-pass-app-config-filename branch July 4, 2025 01:01
@github-actions github-actions Bot mentioned this pull request Jul 14, 2025
@github-actions github-actions Bot mentioned this pull request Aug 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants