[K8s Plugin] Remove unnecessary func and if-else#5998
Merged
Conversation
Signed-off-by: Shinnosuke Sawada-Dazai <shin@warashi.dev>
Signed-off-by: Shinnosuke Sawada-Dazai <shin@warashi.dev>
Signed-off-by: Shinnosuke Sawada-Dazai <shin@warashi.dev>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5998 +/- ##
==========================================
- Coverage 28.23% 28.16% -0.08%
==========================================
Files 519 519
Lines 56017 55937 -80
==========================================
- Hits 15818 15756 -62
+ Misses 38945 38931 -14
+ Partials 1254 1250 -4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Warashi
commented
Jul 4, 2025
Comment on lines
-50
to
-51
| // BuildApplicationLiveState builds the live state of the application from the given manifests. | ||
| func BuildApplicationLiveState(deploytarget string, manifests []Manifest, now time.Time) *model.ApplicationLiveState { |
Member
Author
There was a problem hiding this comment.
This is an old implementation that was implemented before using the SDK.
Comment on lines
-208
to
-211
| if model.IsApplicationConfigFile(d.Name()) { | ||
| // MEMO: can we remove this check because we have configFilename? | ||
| return nil | ||
| } |
Member
Author
There was a problem hiding this comment.
Before #5987, the configFilename was an empty string, so this is needed.
But now, we can remove this if clause.
khanhtc1202
approved these changes
Jul 4, 2025
Member
khanhtc1202
left a comment
khanhtc1202
left a comment
There was a problem hiding this comment.
Got it, this change to remove pipecd from as direct dependency of plugins 👍
t-kikuc
approved these changes
Jul 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does:
as title
Why we need it:
to hardening codebase
Which issue(s) this PR fixes:
Part of #5764
Does this PR introduce a user-facing change?: