Skip to content

[PlanPreview Plugin] Implemented SDK-side#6004

Merged
t-kikuc merged 5 commits into
masterfrom
plugin/planpreview/2-sdk
Jul 4, 2025
Merged

[PlanPreview Plugin] Implemented SDK-side#6004
t-kikuc merged 5 commits into
masterfrom
plugin/planpreview/2-sdk

Conversation

@t-kikuc
Copy link
Copy Markdown
Member

@t-kikuc t-kikuc commented Jul 4, 2025

What this PR does:

Defined PlanPreviewPlugin

Why we need it:

Make it easier to develop PlanPreview feature for plugins

Which issue(s) this PR fixes:

Part of #5985

Does this PR introduce a user-facing change?:

  • How are users affected by this change:
  • Is this breaking change:
  • How to migrate (if breaking change):

t-kikuc added 2 commits July 4, 2025 16:20
Signed-off-by: t-kikuc <tkikuchi07f@gmail.com>
Signed-off-by: t-kikuc <tkikuchi07f@gmail.com>
@t-kikuc t-kikuc requested a review from a team as a code owner July 4, 2025 07:30
@github-actions github-actions Bot added area/go area/plugin-sdk piped-plugin-sdk labels Jul 4, 2025
@codecov
Copy link
Copy Markdown

codecov Bot commented Jul 4, 2025

Codecov Report

Attention: Patch coverage is 45.20548% with 40 lines in your changes missing coverage. Please review.

Project coverage is 28.19%. Comparing base (da6fce4) to head (c05619e).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
pkg/plugin/sdk/planpreview.go 55.00% 26 Missing and 1 partial ⚠️
pkg/plugin/sdk/plugin.go 0.00% 13 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6004      +/-   ##
==========================================
+ Coverage   28.16%   28.19%   +0.02%     
==========================================
  Files         519      520       +1     
  Lines       55938    56011      +73     
==========================================
+ Hits        15757    15790      +33     
- Misses      38931    38970      +39     
- Partials     1250     1251       +1     
Flag Coverage Δ
. 23.22% <ø> (ø)
.-pkg-app-pipedv1-plugin-kubernetes 66.27% <ø> (ø)
.-pkg-app-pipedv1-plugin-kubernetes_multicluster 67.33% <ø> (ø)
.-pkg-app-pipedv1-plugin-terraform 80.26% <ø> (ø)
.-pkg-app-pipedv1-plugin-wait 35.51% <ø> (ø)
.-pkg-plugin-sdk 50.71% <45.20%> (-0.22%) ⬇️
.-tool-actions-gh-release 19.23% <ø> (ø)
.-tool-actions-plan-preview 25.30% <ø> (ø)
.-tool-codegen-protoc-gen-auth 0.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

t-kikuc added 3 commits July 4, 2025 16:36
Signed-off-by: t-kikuc <tkikuchi07f@gmail.com>
Signed-off-by: t-kikuc <tkikuchi07f@gmail.com>
Signed-off-by: t-kikuc <tkikuchi07f@gmail.com>
Copy link
Copy Markdown
Member

@ffjlabo ffjlabo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

"github.com/pipe-cd/pipecd/pkg/plugin/api/v1alpha1/planpreview"
)

// PlanPreviewPlugin is the interface that must be implemented by a PlanPreview plugin.
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// PlanPreviewPlugin is the interface that must be implemented by a PlanPreview plugin.
// PlanPreviewPlugin is the interface that a PlanPreview-supported plugin must implement.

nits

Copy link
Copy Markdown
Member

@Warashi Warashi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Copy Markdown
Member

@khanhtc1202 khanhtc1202 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍

@t-kikuc t-kikuc merged commit 038a2c6 into master Jul 4, 2025
37 of 40 checks passed
@t-kikuc t-kikuc deleted the plugin/planpreview/2-sdk branch July 4, 2025 07:46
@github-actions github-actions Bot mentioned this pull request Jul 14, 2025
@github-actions github-actions Bot mentioned this pull request Aug 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants