Skip to content

lint: Remove unused 'pluginName' to fix lint error#6007

Merged
t-kikuc merged 1 commit into
masterfrom
fix-lint_pluginName
Jul 7, 2025
Merged

lint: Remove unused 'pluginName' to fix lint error#6007
t-kikuc merged 1 commit into
masterfrom
fix-lint_pluginName

Conversation

@t-kikuc
Copy link
Copy Markdown
Member

@t-kikuc t-kikuc commented Jul 4, 2025

What this PR does:

as title

Why we need it:

To suppress this lint error:

INFO [runner] linters took 535.982544ms with stages: goanalysis_metalinter: 534.031616ms 
deployment.go:417:36: `newPipelineSyncStagesResponse` - `pluginName` is unused (unparam)
func newPipelineSyncStagesResponse(pluginName string, now time.Time, request *deployment.BuildPipelineSyncStagesRequest, response *BuildPipelineSyncStagesResponse) (*deployment.BuildPipelineSyncStagesResponse, error) {
               

The cause: #6004 removed unused Name() and pluginName became unused.

Which issue(s) this PR fixes:

Does this PR introduce a user-facing change?:

  • How are users affected by this change:
  • Is this breaking change:
  • How to migrate (if breaking change):

Signed-off-by: t-kikuc <tkikuchi07f@gmail.com>
@t-kikuc t-kikuc requested a review from a team as a code owner July 4, 2025 09:43
@t-kikuc t-kikuc enabled auto-merge (squash) July 4, 2025 09:43
@github-actions github-actions Bot added area/go area/plugin-sdk piped-plugin-sdk labels Jul 4, 2025
@codecov
Copy link
Copy Markdown

codecov Bot commented Jul 4, 2025

Codecov Report

❌ Patch coverage is 80.00000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 28.19%. Comparing base (038a2c6) to head (cb512df).
⚠️ Report is 361 commits behind head on master.

Files with missing lines Patch % Lines
pkg/plugin/sdk/deployment.go 80.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #6007   +/-   ##
=======================================
  Coverage   28.19%   28.19%           
=======================================
  Files         520      520           
  Lines       56011    56011           
=======================================
  Hits        15790    15790           
  Misses      38970    38970           
  Partials     1251     1251           
Flag Coverage Δ
. 23.22% <ø> (ø)
.-pkg-app-pipedv1-plugin-kubernetes 66.27% <ø> (ø)
.-pkg-app-pipedv1-plugin-kubernetes_multicluster 67.33% <ø> (ø)
.-pkg-app-pipedv1-plugin-terraform 80.26% <ø> (ø)
.-pkg-app-pipedv1-plugin-wait 35.51% <ø> (ø)
.-pkg-plugin-sdk 50.71% <80.00%> (ø)
.-tool-actions-gh-release 19.23% <ø> (ø)
.-tool-actions-plan-preview 25.30% <ø> (ø)
.-tool-codegen-protoc-gen-auth 0.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Copy Markdown
Member

@khanhtc1202 khanhtc1202 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch 👍

Copy link
Copy Markdown
Member

@Warashi Warashi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@t-kikuc t-kikuc merged commit 5e39f0f into master Jul 7, 2025
40 checks passed
@t-kikuc t-kikuc deleted the fix-lint_pluginName branch July 7, 2025 04:48
@github-actions github-actions Bot mentioned this pull request Jul 14, 2025
@github-actions github-actions Bot mentioned this pull request Aug 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants