Ensure Template Rendering for All Analysis Stage Strategies#6010
Merged
ffjlabo merged 1 commit intoJul 8, 2025
Conversation
mohammedfirdouss
changed the title
Contributor
Author
|
@Warashi I think this is ready for a review? |
Member
|
@mohammedfirdouss |
Warashi
reviewed
Jul 7, 2025
Contributor
Author
|
@Warashi Thanks for that. I would check it out. |
mohammedfirdouss
force-pushed
the
analysis-template-rendering
branch
from
4a9c67b to
fe89c8e
Compare
Signed-off-by: mohammedfirdouss <mohammedfirdousaraoye@gmail.com>
mohammedfirdouss
force-pushed
the
analysis-template-rendering
branch
from
fe89c8e to
1a8ed9c
Compare
ffjlabo
approved these changes
Jul 8, 2025
Member
ffjlabo
left a comment
ffjlabo
left a comment
There was a problem hiding this comment.
Thank you for the contribution! LGTM!
Contributor
Author
github-actions Bot
pushed a commit
that referenced
this pull request
Jul 14, 2025
Signed-off-by: mohammedfirdouss <mohammedfirdousaraoye@gmail.com> Signed-off-by: pipecd-bot <pipecd.dev@gmail.com>
This was referenced Jul 14, 2025
Merged
github-actions Bot
pushed a commit
that referenced
this pull request
Jul 14, 2025
Signed-off-by: mohammedfirdouss <mohammedfirdousaraoye@gmail.com> Signed-off-by: pipecd-bot <pipecd.dev@gmail.com>
ffjlabo
added a commit
that referenced
this pull request
Jul 14, 2025
* refactor metricsAnalyzer to render queries before execution. (#6010) Signed-off-by: mohammedfirdouss <mohammedfirdousaraoye@gmail.com> Signed-off-by: pipecd-bot <pipecd.dev@gmail.com> * Update piped-base container image version (#6018) Signed-off-by: pipecd-bot <pipecd.dev@gmail.com> * Update piped-base-okd image for piped and launcher (#6023) Signed-off-by: khanhtc1202 <khanhtc1202@gmail.com> Signed-off-by: pipecd-bot <pipecd.dev@gmail.com> * Cut release v0.52.2 (#6027) Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: ffjlabo <40124947+ffjlabo@users.noreply.github.com> Signed-off-by: pipecd-bot <pipecd.dev@gmail.com> --------- Signed-off-by: mohammedfirdouss <mohammedfirdousaraoye@gmail.com> Signed-off-by: pipecd-bot <pipecd.dev@gmail.com> Signed-off-by: khanhtc1202 <khanhtc1202@gmail.com> Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Mohammed Firdous <124298708+mohammedfirdouss@users.noreply.github.com> Co-authored-by: Khanh Tran <32532742+khanhtc1202@users.noreply.github.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: ffjlabo <40124947+ffjlabo@users.noreply.github.com>
8 tasks
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This MR ensures that all ANALYSIS stage strategies (including
THRESHOLDandPREVIOUS) render their query templates before use, just likeCANARY_BASELINEalready does.Why
Previously, template variables (e.g.,
{{ .App.Name }}) were not rendered forTHRESHOLDandPREVIOUSstrategies, resulting in raw template strings in logs and queries.This change unifies the behavior and ensures all strategies support dynamic values, improving log clarity and query correctness.
How
metrics_analyzer.goto userenderQueryfor all strategies.Impact
Related Issue
Closes #6005