Skip to content

Ensure Template Rendering for All Analysis Stage Strategies #6010

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ffjlabo merged 1 commit into from
Jul 8, 2025
Merged

Ensure Template Rendering for All Analysis Stage Strategies #6010

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 21 additions & 13 deletions pkg/app/piped/executor/analysis/metrics_analyzer.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,8 +133,12 @@ func (a *metricsAnalyzer) analyzeWithThreshold(ctx context.Context) (bool, error
To: now,
}

a.logPersister.Infof("[%s] Run query: %q, in range: %v", a.id, a.cfg.Query, queryRange)
points, err := a.provider.QueryPoints(ctx, a.cfg.Query, queryRange)
renderedQuery, err := a.renderQuery(a.cfg.Query, a.cfg.PrimaryArgs, primaryVariantName)
if err != nil {
return false, fmt.Errorf("failed to render query template for Threshold: %w", err)
}
a.logPersister.Infof("[%s] Run query: %q, in range: %v", a.id, renderedQuery, queryRange)
points, err := a.provider.QueryPoints(ctx, renderedQuery, queryRange)
if err != nil {
return false, fmt.Errorf("failed to run query: %w", err)
}
Expand All @@ -154,7 +158,7 @@ func (a *metricsAnalyzer) analyzeWithThreshold(ctx context.Context) (bool, error
break
}
if !expected {
a.logPersister.Errorf("[%s] Failed because it found a data point (%s) that is outside the expected range (%s). Performed query: %q", a.id, &outiler, &a.cfg.Expected, a.cfg.Query)
a.logPersister.Errorf("[%s] Failed because it found a data point (%s) that is outside the expected range (%s). Performed query: %q", a.id, &outiler, &a.cfg.Expected, renderedQuery)
return false, nil
}

Expand All @@ -171,13 +175,17 @@ func (a *metricsAnalyzer) analyzeWithPrevious(ctx context.Context) (expected, fi
To: now,
}

a.logPersister.Infof("[%s] Run query: %q, in range: %v", a.id, a.cfg.Query, queryRange)
points, err := a.provider.QueryPoints(ctx, a.cfg.Query, queryRange)
renderedQuery, err := a.renderQuery(a.cfg.Query, a.cfg.PrimaryArgs, primaryVariantName)
if err != nil {
return false, false, fmt.Errorf("failed to render query template for Previous: %w", err)
}
a.logPersister.Infof("[%s] Run query: %q, in range: %v", a.id, renderedQuery, queryRange)
points, err := a.provider.QueryPoints(ctx, renderedQuery, queryRange)
if err != nil {
return false, false, fmt.Errorf("failed to run query: %w: performed query: %q", err, a.cfg.Query)
return false, false, fmt.Errorf("failed to run query: %w: performed query: %q", err, renderedQuery)
}
pointsCount := len(points)
a.logPersister.Infof("[%s] Got %d data points for current Primary from the query: %q", a.id, pointsCount, a.cfg.Query)
a.logPersister.Infof("[%s] Got %d data points for current Primary from the query: %q", a.id, pointsCount, renderedQuery)
values := make([]float64, 0, pointsCount)
for i := range points {
values = append(values, points[i].Value)
Expand All @@ -199,28 +207,28 @@ func (a *metricsAnalyzer) analyzeWithPrevious(ctx context.Context) (expected, fi
To: prevTo,
}

a.logPersister.Infof("[%s] Run query: %q, in range: %v", a.id, a.cfg.Query, prevQueryRange)
prevPoints, err := a.provider.QueryPoints(ctx, a.cfg.Query, prevQueryRange)
a.logPersister.Infof("[%s] Run query: %q, in range: %v", a.id, renderedQuery, prevQueryRange)
prevPoints, err := a.provider.QueryPoints(ctx, renderedQuery, prevQueryRange)
if err != nil {
return false, false, fmt.Errorf("failed to run query to fetch metrics for the previous deployment: %w: performed query: %q", err, a.cfg.Query)
return false, false, fmt.Errorf("failed to run query to fetch metrics for the previous deployment: %w: performed query: %q", err, renderedQuery)
}
prevPointsCount := len(prevPoints)
a.logPersister.Infof("[%s] Got %d data points for previous Primary from the query: %q", a.id, prevPointsCount, a.cfg.Query)
a.logPersister.Infof("[%s] Got %d data points for previous Primary from the query: %q", a.id, prevPointsCount, renderedQuery)
prevValues := make([]float64, 0, prevPointsCount)
for i := range prevPoints {
prevValues = append(prevValues, prevPoints[i].Value)
}
expected, err = a.compare(values, prevValues, a.cfg.Deviation)
if err != nil {
a.logPersister.Errorf("[%s] Failed to compare data points: %v", a.id, err)
a.logPersister.Infof("[%s] Performed query: %q", a.id, a.cfg.Query)
a.logPersister.Infof("[%s] Performed query: %q", a.id, renderedQuery)
return false, false, err
}
if !expected {
a.logPersister.Errorf("[%s] The difference between Current Primary and Previous one is statistically significant", a.id)
a.logPersister.Infof("[%s] Performed query range for current Primary: %q", a.id, &queryRange)
a.logPersister.Infof("[%s] Performed query range for previous Primary: %q", a.id, &prevQueryRange)
a.logPersister.Infof("[%s] Performed query: %q", a.id, a.cfg.Query)
a.logPersister.Infof("[%s] Performed query: %q", a.id, renderedQuery)
a.logPersister.Infof("[%s] Current data points acquired:", a.id)
for i := range points {
a.logPersister.Infof("[%s] %s", a.id, &points[i])
Expand Down