Redux replace application detail page#6025
Merged
Merged
Conversation
This was referenced Jul 7, 2025
Contributor
|
This PR is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 7 days. |
hongky-1994
force-pushed
the
redux-replace-application-detail-page
branch
from
ed8bcc2 to
47f0c57
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #6025 +/- ##
==========================================
- Coverage 28.78% 28.77% -0.02%
==========================================
Files 559 559
Lines 59523 59523
==========================================
- Hits 17131 17125 -6
- Misses 41078 41084 +6
Partials 1314 1314
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
hongky-1994
force-pushed
the
redux-replace-application-detail-page
branch
2 times, most recently
from
1202bec to
247bd91
Compare
- remove redux modules/applicaitons-live-stage - remove redux modules/delete-application - remove redux modules/sealed-secret - add query for - get application state by id - delete applicaiton - disable appliation - enable application - sync application - generate sealed secret - update test case Signed-off-by: kypham <hongkyhvnh@gmail.com>
hongky-1994
force-pushed
the
redux-replace-application-detail-page
branch
from
247bd91 to
3bded28
Compare
khanhtc1202
approved these changes
Sep 10, 2025
Member
khanhtc1202
left a comment
khanhtc1202
left a comment
There was a problem hiding this comment.
LGTM 👌
Confirmed on my local.
t-kikuc
approved these changes
Sep 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does:
Why we need it:
Which issue(s) this PR fixes:
Partof #5868
Does this PR introduce a user-facing change?: