Skip to content

Redux replace application list#6034

Merged
khanhtc1202 merged 1 commit into
masterfrom
redux-replace-application-list
Sep 11, 2025
Merged

Redux replace application list#6034
khanhtc1202 merged 1 commit into
masterfrom
redux-replace-application-list

Conversation

@hongky-1994
Copy link
Copy Markdown
Contributor

What this PR does:

Why we need it:

  • Remove redux from application detail page.

Which issue(s) this PR fixes:

Partof #5868

Does this PR introduce a user-facing change?:

  • How are users affected by this change:
  • Is this breaking change:
  • How to migrate (if breaking change):

@github-actions
Copy link
Copy Markdown
Contributor

This PR is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 7 days.

@github-actions github-actions Bot added the Stale label Aug 16, 2025
@hongky-1994 hongky-1994 removed the Stale label Aug 18, 2025
@hongky-1994 hongky-1994 force-pushed the redux-replace-application-list branch from 473e31a to ab8184a Compare September 4, 2025 03:55
@codecov
Copy link
Copy Markdown

codecov Bot commented Sep 4, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 45.02%. Comparing base (b1f1553) to head (7ade28e).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff             @@
##           master    #6034       +/-   ##
===========================================
+ Coverage   28.76%   45.02%   +16.25%     
===========================================
  Files         559      100      -459     
  Lines       59526     8710    -50816     
===========================================
- Hits        17125     3922    -13203     
+ Misses      41087     4564    -36523     
+ Partials     1314      224     -1090     
Flag Coverage Δ
. ?
.-pkg-app-pipedv1-plugin-analysis 32.64% <ø> (ø)
.-pkg-app-pipedv1-plugin-kubernetes ?
.-pkg-app-pipedv1-plugin-kubernetes_multicluster 67.48% <ø> (ø)
.-pkg-app-pipedv1-plugin-scriptrun 54.83% <ø> (ø)
.-pkg-app-pipedv1-plugin-terraform 39.49% <ø> (ø)
.-pkg-app-pipedv1-plugin-wait 35.51% <ø> (ø)
.-pkg-app-pipedv1-plugin-waitapproval 55.73% <ø> (ø)
.-pkg-plugin-sdk 50.37% <ø> (ø)
.-tool-actions-gh-release 19.23% <ø> (ø)
.-tool-actions-plan-preview 25.51% <ø> (ø)
.-tool-codegen-protoc-gen-auth 0.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@hongky-1994 hongky-1994 force-pushed the redux-replace-application-list branch 2 times, most recently from 973026c to 74ef50f Compare September 10, 2025 02:28
- Add query for get unregisted apps
- Add mutation for add app, update app
- Update test cases

Signed-off-by: kypham <hongkyhvnh@gmail.com>
@hongky-1994 hongky-1994 force-pushed the redux-replace-application-list branch from 74ef50f to 7ade28e Compare September 10, 2025 08:58
@hongky-1994 hongky-1994 marked this pull request as ready for review September 10, 2025 17:03
@hongky-1994 hongky-1994 requested review from a team as code owners September 10, 2025 17:03
Copy link
Copy Markdown
Member

@khanhtc1202 khanhtc1202 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, confirm on my local 👌

@khanhtc1202 khanhtc1202 enabled auto-merge (squash) September 11, 2025 07:05
@khanhtc1202 khanhtc1202 merged commit d72581e into master Sep 11, 2025
45 checks passed
@khanhtc1202 khanhtc1202 deleted the redux-replace-application-list branch September 11, 2025 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants