Skip to content

Redux remove package#6046

Merged
ffjlabo merged 1 commit into
masterfrom
redux-remove-package
Sep 12, 2025
Merged

Redux remove package#6046
ffjlabo merged 1 commit into
masterfrom
redux-remove-package

Conversation

@hongky-1994
Copy link
Copy Markdown
Contributor

What this PR does:

  • This MR depends on Redux replace application list #6034
  • update test case and test utils
  • fix wrong typo use-get-appliation-counts
  • remove react-redux, redux-thunk, @reduxjs/toolkit, redux-mock-store

Why we need it:

  • Completely remove redux packages.

Which issue(s) this PR fixes:

Partof #5868

Does this PR introduce a user-facing change?:

  • How are users affected by this change:
  • Is this breaking change:
  • How to migrate (if breaking change):

@github-actions
Copy link
Copy Markdown
Contributor

This PR is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 7 days.

@codecov
Copy link
Copy Markdown

codecov Bot commented Sep 4, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 28.77%. Comparing base (c92498c) to head (bf91ab2).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6046      +/-   ##
==========================================
- Coverage   28.78%   28.77%   -0.01%     
==========================================
  Files         538      559      +21     
  Lines       57944    59526    +1582     
==========================================
+ Hits        16680    17131     +451     
- Misses      39987    41081    +1094     
- Partials     1277     1314      +37     
Flag Coverage Δ
. 23.24% <ø> (ø)
.-pkg-app-pipedv1-plugin-analysis 32.64% <ø> (ø)
.-pkg-app-pipedv1-plugin-kubernetes 60.24% <ø> (ø)
.-pkg-app-pipedv1-plugin-kubernetes_multicluster 67.48% <ø> (ø)
.-pkg-app-pipedv1-plugin-scriptrun 54.83% <ø> (ø)
.-pkg-app-pipedv1-plugin-terraform 39.49% <ø> (?)
.-pkg-app-pipedv1-plugin-wait 35.51% <ø> (?)
.-pkg-app-pipedv1-plugin-waitapproval 55.73% <ø> (ø)
.-pkg-plugin-sdk 50.37% <ø> (ø)
.-tool-actions-gh-release 19.23% <ø> (?)
.-tool-actions-plan-preview 25.51% <ø> (ø)
.-tool-codegen-protoc-gen-auth 0.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@hongky-1994 hongky-1994 force-pushed the redux-remove-package branch 5 times, most recently from cd93554 to cc92b54 Compare September 11, 2025 16:29
@hongky-1994 hongky-1994 marked this pull request as ready for review September 12, 2025 03:15
@hongky-1994 hongky-1994 requested review from a team as code owners September 12, 2025 03:15
- update test case and test utils
- fix wrong typo use-get-appliation-counts
- remove react-redux, redux-thunk, @reduxjs/toolkit, redux-mock-store

Signed-off-by: kypham <hongkyhvnh@gmail.com>
Copy link
Copy Markdown
Member

@khanhtc1202 khanhtc1202 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work 🎉
Confirmed on my local, thanks!

Copy link
Copy Markdown
Member

@ffjlabo ffjlabo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!!

@ffjlabo ffjlabo merged commit bfa2235 into master Sep 12, 2025
44 of 45 checks passed
@ffjlabo ffjlabo deleted the redux-remove-package branch September 12, 2025 05:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants