Skip to content

Bump go 1.25.0#6128

Merged
Warashi merged 4 commits into
pipe-cd:masterfrom
Okabe-Junya:bump-go1.25
Sep 8, 2025
Merged

Bump go 1.25.0#6128
Warashi merged 4 commits into
pipe-cd:masterfrom
Okabe-Junya:bump-go1.25

Conversation

@Okabe-Junya
Copy link
Copy Markdown
Member

@Okabe-Junya Okabe-Junya commented Aug 15, 2025 •
edited
Loading

What this PR does:

Why we need it:

General maintenance PR

c.f. Go 1.25 is released 🎉

Which issue(s) this PR fixes:

N/A

Does this PR introduce a user-facing change?:

None

@Okabe-Junya Okabe-Junya force-pushed the bump-go1.25 branch 2 times, most recently from ef3eb7c to bd3268b Compare August 15, 2025 19:29
@Okabe-Junya Okabe-Junya marked this pull request as ready for review August 15, 2025 19:30
@Okabe-Junya Okabe-Junya requested a review from a team as a code owner August 15, 2025 19:30
@Okabe-Junya
Copy link
Copy Markdown
Member Author

Okabe-Junya commented Aug 15, 2025

Another topic: should we use Go toolchains instead of just bump?
(Actually, I prefer using toolchain directive)

@Okabe-Junya Okabe-Junya mentioned this pull request Aug 18, 2025
Merged
@Okabe-Junya
Copy link
Copy Markdown
Member Author

Okabe-Junya commented Aug 18, 2025 •
edited
Loading

Some CI errors were caused by:

  1. Codegen image was built with Go 1.24 (compatibility issue)
  2. mockgen 0.5.0 did not support Go 1.25 (indirect dependency issue)

To address 1, I opened #6134, and to address 2, I've also bumped mockgen in this PR.

Once 6134 merged, I will rebase this PR and fix all CI errors maybe, thanks!

@khanhtc1202
Copy link
Copy Markdown
Member

khanhtc1202 commented Aug 19, 2025

Got it, let review and merge #6134 first 👌

@khanhtc1202
Copy link
Copy Markdown
Member

khanhtc1202 commented Aug 21, 2025

@Okabe-Junya Since #6134 and #6141 were merged, could you rebase this PR 👀

@codecov
Copy link
Copy Markdown

codecov Bot commented Aug 21, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 25.30%. Comparing base (4d42ed8) to head (41eb340).
⚠️ Report is 11 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #6128      +/-   ##
==========================================
- Coverage   28.66%   25.30%   -3.36%     
==========================================
  Files         536        3     -533     
  Lines       57353      486   -56867     
==========================================
- Hits        16442      123   -16319     
+ Misses      39633      356   -39277     
+ Partials     1278        7    -1271
Flag Coverage Δ
. ?
.-pkg-app-pipedv1-plugin-analysis ?
.-pkg-app-pipedv1-plugin-kubernetes ?
.-pkg-app-pipedv1-plugin-kubernetes_multicluster ?
.-pkg-app-pipedv1-plugin-scriptrun ?
.-pkg-app-pipedv1-plugin-terraform ?
.-pkg-app-pipedv1-plugin-wait ?
.-pkg-app-pipedv1-plugin-waitapproval ?
.-pkg-plugin-sdk ?
.-tool-actions-gh-release ?
.-tool-actions-plan-preview 25.30% <ø> (ø)
.-tool-codegen-protoc-gen-auth ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Okabe-Junya
Copy link
Copy Markdown
Member Author

Okabe-Junya commented Aug 21, 2025

Thanks, just rebased but some CI errors happened..

It looks generating codegen package didn't work well...
cf.

@Okabe-Junya
Copy link
Copy Markdown
Member Author

Okabe-Junya commented Aug 21, 2025

I have another schedule for now, so will take a look later

@khanhtc1202
Copy link
Copy Markdown
Member

khanhtc1202 commented Aug 21, 2025

https://github.com/pipe-cd/pipecd/actions/runs/17116983120/job/48549930616?pr=6128 job failed 👀

Since the package in go.mod required golang v1.25.0, I think we have to update the gen.yaml workflow file and Makefile to make it pass
ref:
https://github.com/pipe-cd/pipecd/blob/master/.github/workflows/gen.yaml#L14-L15
https://github.com/pipe-cd/pipecd/blob/master/Makefile#L258-L261

This is the latest codegen published by PR #6134
https://github.com/pipe-cd/pipecd/pkgs/container/codegen/492580035?tag=v0.53.0-10-g64742f7

@khanhtc1202
Copy link
Copy Markdown
Member

khanhtc1202 commented Aug 21, 2025

The failed job at https://github.com/pipe-cd/pipecd/actions/runs/17115379565/job/48545100329 is caused by an oracle-vm issue with the emulator, which is unstable for now. Let's ignore it by rerunning for now; we can check it later by separate issues/PRs.

@Okabe-Junya
Copy link
Copy Markdown
Member Author

Okabe-Junya commented Aug 21, 2025

This is the latest codegen published by PR #6134
https://github.com/pipe-cd/pipecd/pkgs/container/codegen/492580035?tag=v0.53.0-10-g64742f7

Oh sorry, I missed this one...
Updated in a2a7541

@Okabe-Junya
Copy link
Copy Markdown
Member Author

Okabe-Junya commented Aug 21, 2025

The failed job at ... which is unstable for now. Let's ignore it by rerunning for now; we can check it later by separate issues/PRs.

Sounds good. Maybe related to #6113?
Anyway, let's leave this aside in this PR.

@Okabe-Junya
Copy link
Copy Markdown
Member Author

Okabe-Junya commented Aug 21, 2025

Flaky CI or GitHub Actions incident ...

cf. https://github.com/pipe-cd/pipecd/actions/runs/17133759923/job/48604456434

The job was not acquired by Runner of type hosted even after multiple attempts
Internal server error. Correlation ID: fcb4b24f-8324-407b-934b-e7afbad792a7

Will try to re-run tomorrow

Warashi
Warashi previously approved these changes Aug 25, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@Warashi Warashi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you!

Warashi
Warashi reviewed Aug 25, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@Warashi Warashi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have to bump golangci-lint too.

Comment thread .github/workflows/lint.yaml Outdated
@Warashi Warashi dismissed their stale review August 25, 2025 02:56

We have to bump golangci-lint first.
I dismiss this review to avoid mistakenly merging this PR.

This was referenced Aug 26, 2025
Closed
Closed
Merged
@Okabe-Junya Okabe-Junya marked this pull request as draft August 26, 2025 15:14
@Okabe-Junya
Copy link
Copy Markdown
Member Author

Okabe-Junya commented Aug 26, 2025

Before moving foward with this PR, we need to migrate golangci-lint to v2. see - #6128 (comment)
And I just opened #6178 to migrate golangci-lint to v2.

Once we merged 6178, let's move forward with this PR :)

@Okabe-Junya Okabe-Junya self-assigned this Sep 5, 2025
@Okabe-Junya Okabe-Junya marked this pull request as ready for review September 5, 2025 16:51
@Okabe-Junya Okabe-Junya requested a review from Warashi September 5, 2025 16:51
@Okabe-Junya
Copy link
Copy Markdown
Member Author

Okabe-Junya commented Sep 5, 2025

Before moving foward with this PR, we need to migrate golangci-lint to v2. see - #6128 (comment) And I just opened #6178 to migrate golangci-lint to v2.

Once we merged 6178, let's move forward with this PR :)

Time is coming!
I rebased fresh master and all CIs are green :)

PTAL this PR, thanks!

Warashi
Warashi reviewed Sep 6, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@Warashi Warashi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, we added another workflow and Dockerfile in the PR #6194.
Please update these too?

@Okabe-Junya
bump go 1.25.0
764dac4 
Signed-off-by: Junya Okabe <okabe.junya.qj@alumni.tsukuba.ac.jp>
@Okabe-Junya
chore: bump version
cbd22c1 
Signed-off-by: Junya Okabe <okabe.junya.qj@alumni.tsukuba.ac.jp>
@Okabe-Junya
chore: update sha256
8b6e368 
Signed-off-by: Junya Okabe <okabe.junya.qj@alumni.tsukuba.ac.jp>
@Okabe-Junya
bump: pipedv1
5ab030d 
Signed-off-by: Junya Okabe <okabe.junya.qj@alumni.tsukuba.ac.jp>
khanhtc1202
khanhtc1202 approved these changes Sep 7, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@khanhtc1202 khanhtc1202 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you 🙌

@Okabe-Junya Okabe-Junya requested a review from Warashi September 7, 2025 18:03
Warashi
Warashi approved these changes Sep 8, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@Warashi Warashi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏻

@Warashi Warashi merged commit e1d78ff into pipe-cd:master Sep 8, 2025
48 checks passed
@github-actions github-actions Bot mentioned this pull request Sep 16, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Warashi Warashi Warashi approved these changes

@khanhtc1202 khanhtc1202 khanhtc1202 approved these changes

@ffjlabo ffjlabo Awaiting requested review from ffjlabo ffjlabo is a code owner automatically assigned from pipe-cd/pipecd-approvers

Assignees

@Okabe-Junya Okabe-Junya

Labels

area/build area/go area/pipedv1 area/plugin-sdk piped-plugin-sdk area/tool

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Okabe-Junya @khanhtc1202 @Warashi