Skip to content

Migrate golangci-lint to v2#6178

Merged
khanhtc1202 merged 6 commits into
pipe-cd:masterfrom
Okabe-Junya:fix-6177
Sep 5, 2025
Merged

Migrate golangci-lint to v2#6178
khanhtc1202 merged 6 commits into
pipe-cd:masterfrom
Okabe-Junya:fix-6177

Conversation

@Okabe-Junya
Copy link
Copy Markdown
Member

@Okabe-Junya Okabe-Junya commented Aug 26, 2025 •
edited
Loading

What this PR does:

  • Update golangci-lint to v2.4.0 (for Go 1.25 support)
  • Update reviewdog/action-golangci-lint to v2.8.0 (for golangci-lint v2 support)

Why we need it:

To bump Go 1.25
c.f. #6128 (comment)

Which issue(s) this PR fixes:

Fixes #6177

Does this PR introduce a user-facing change?:

None

@Okabe-Junya Okabe-Junya self-assigned this Aug 26, 2025
@Okabe-Junya
Copy link
Copy Markdown
Member Author

Okabe-Junya commented Aug 26, 2025 •
edited
Loading

@khanhtc1202

Sorry, it seems that running reviewdog/action-golangci-lint@v2.8.0 is not currently allowed. Could you update white-list for it? (Either tag or SHA is fine.)

  • Tag: v2.8.0
  • SHA: f9bba13753278f6a73b27a56a3ffb1bfda90ed71

c.f. https://github.com/pipe-cd/pipecd/actions/runs/17242163036

Error
The action reviewdog/action-golangci-lint@f9bba13753278f6a73b27a56a3ffb1bfda90ed71 is not allowed in pipe-cd/pipecd 
because all actions must be from a repository owned by your enterprise or match one of the patterns: ...

@Okabe-Junya
chore: exec golangci-lint migrate
69f7923 
Signed-off-by: Junya Okabe <okabe.junya.qj@alumni.tsukuba.ac.jp>
@Okabe-Junya
bump some tools
2892490 
Signed-off-by: Junya Okabe <okabe.junya.qj@alumni.tsukuba.ac.jp>
@Okabe-Junya Okabe-Junya mentioned this pull request Aug 26, 2025
Merged
@Okabe-Junya
fix: linter qf errors
413d7d7 
Signed-off-by: Junya Okabe <okabe.junya.qj@alumni.tsukuba.ac.jp>
@github-actions github-actions Bot added area/go area/plugin-sdk piped-plugin-sdk labels Aug 26, 2025
@codecov
Copy link
Copy Markdown

codecov Bot commented Aug 26, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 62.94%. Comparing base (8b0b05c) to head (413d7d7).

Additional details and impacted files 
@@             Coverage Diff             @@
##           master    #6178       +/-   ##
===========================================
+ Coverage   28.44%   62.94%   +34.50%     
===========================================
  Files         537       60      -477     
  Lines       57534     6024    -51510     
===========================================
- Hits        16367     3792    -12575     
+ Misses      39895     1957    -37938     
+ Partials     1272      275      -997
Flag Coverage Δ
. ?
.-pkg-app-pipedv1-plugin-analysis ?
.-pkg-app-pipedv1-plugin-kubernetes 60.24% <ø> (ø)
.-pkg-app-pipedv1-plugin-kubernetes_multicluster 67.48% <ø> (ø)
.-pkg-app-pipedv1-plugin-scriptrun ?
.-pkg-app-pipedv1-plugin-terraform ?
.-pkg-app-pipedv1-plugin-wait ?
.-pkg-app-pipedv1-plugin-waitapproval ?
.-pkg-plugin-sdk ?
.-tool-actions-gh-release ?
.-tool-actions-plan-preview ?
.-tool-codegen-protoc-gen-auth ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@khanhtc1202
Copy link
Copy Markdown
Member

khanhtc1202 commented Aug 28, 2025

@Okabe-Junya Thanks, I added that image to the whitelist 🙆‍♂️

@Okabe-Junya
Merge branch 'master' into fix-6177
117758e 
Signed-off-by: Junya Okabe <86868255+Okabe-Junya@users.noreply.github.com>
@Okabe-Junya Okabe-Junya marked this pull request as ready for review August 28, 2025 14:03
@Okabe-Junya Okabe-Junya requested a review from a team as a code owner August 28, 2025 14:03
@Okabe-Junya
Copy link
Copy Markdown
Member Author

Okabe-Junya commented Aug 28, 2025 •
edited
Loading

Thanks, I re-triggered all CIs and passed!
Please take a look this PR :)

Warashi
Warashi reviewed Sep 1, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@Warashi Warashi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!
We added executestage/mannwhitney as excluded in the PR #6159.
This is lacking in the new configuration.
Please check it?

Comment thread .golangci.yml
Comment on lines -32 to -33
# Relative path of "pkg/app/pipedv1/plugin/analysis/executestage/mannwhitney"
- "executestage/mannwhitney"
Copy link
Copy Markdown
Member

@Warashi Warashi Sep 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The executestage/mannwhitney is lacking in the new configuration.

Copy link
Copy Markdown
Member Author

@Okabe-Junya Okabe-Junya Sep 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, good point
fixed in ea0220e :)

Okabe-Junya and others added 2 commits September 4, 2025 17:54
@Okabe-Junya
fix: golangci.yaml
ea0220e 
Signed-off-by: Junya Okabe <okabe.junya.qj@alumni.tsukuba.ac.jp>
@Okabe-Junya
Merge branch 'master' into fix-6177
3723911
@Okabe-Junya Okabe-Junya requested a review from Warashi September 4, 2025 09:02
Warashi
Warashi approved these changes Sep 4, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@Warashi Warashi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you!

khanhtc1202
khanhtc1202 approved these changes Sep 5, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@khanhtc1202 khanhtc1202 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🙆‍♂️

@khanhtc1202 khanhtc1202 merged commit 172c4ae into pipe-cd:master Sep 5, 2025
42 checks passed
@Okabe-Junya Okabe-Junya deleted the fix-6177 branch September 5, 2025 08:10
@github-actions github-actions Bot mentioned this pull request Sep 16, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Warashi Warashi Warashi approved these changes

@khanhtc1202 khanhtc1202 khanhtc1202 approved these changes

@t-kikuc t-kikuc Awaiting requested review from t-kikuc t-kikuc is a code owner automatically assigned from pipe-cd/pipecd-approvers

Assignees

@Okabe-Junya Okabe-Junya

Labels

area/build area/go area/plugin-sdk piped-plugin-sdk

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Migrate golangci-lint to v2

3 participants

@Okabe-Junya @khanhtc1202 @Warashi