Skip to content

[Analysis Plugin] Import configs#6153

Merged
t-kikuc merged 6 commits into
masterfrom
plugin/analysis/config-stage-app
Aug 28, 2025
Merged

[Analysis Plugin] Import configs#6153
t-kikuc merged 6 commits into
masterfrom
plugin/analysis/config-stage-app

Conversation

@t-kikuc
Copy link
Copy Markdown
Member

@t-kikuc t-kikuc commented Aug 25, 2025

What this PR does:

  • configv1/analysis.go -> condition.go (move and modify unit)
  • configv1/application.go -> stage.go (extract)
  • configv1/analysis_template.go -> analysis_template.go (move and modify)
  • configv1/piped.go -> piped.go (extract)
  • model/analysisprovider.go -> analysisprovider.go (move)

Why we need it:

to support analysis in pipedv1 too with the same config

Which issue(s) this PR fixes:

part of #6068

Does this PR introduce a user-facing change?:

  • How are users affected by this change:
  • Is this breaking change:
  • How to migrate (if breaking change):

Signed-off-by: t-kikuc <tkikuchi07f@gmail.com>
Signed-off-by: t-kikuc <tkikuchi07f@gmail.com>
Signed-off-by: t-kikuc <tkikuchi07f@gmail.com>
Signed-off-by: t-kikuc <tkikuchi07f@gmail.com>
Signed-off-by: t-kikuc <tkikuchi07f@gmail.com>
@codecov
Copy link
Copy Markdown

codecov Bot commented Aug 25, 2025

Codecov Report

❌ Patch coverage is 11.55779% with 176 lines in your changes missing coverage. Please review.
✅ Project coverage is 28.51%. Comparing base (7926e50) to head (9d82ade).
⚠️ Report is 19 commits behind head on master.

Files with missing lines Patch % Lines
pkg/app/pipedv1/plugin/analysis/config/piped.go 0.00% 113 Missing ⚠️
pkg/app/pipedv1/plugin/analysis/config/stage.go 13.51% 32 Missing ⚠️
...ipedv1/plugin/analysis/config/analysis_template.go 38.29% 19 Missing and 10 partials ⚠️
...pipedv1/plugin/analysis/config/analysisprovider.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6153      +/-   ##
==========================================
- Coverage   28.56%   28.51%   -0.06%     
==========================================
  Files         534      537       +3     
  Lines       57123    57259     +136     
==========================================
+ Hits        16317    16327      +10     
- Misses      39541    39661     +120     
- Partials     1265     1271       +6     
Flag Coverage Δ
. 23.12% <ø> (-0.01%) ⬇️
.-pkg-app-pipedv1-plugin-analysis 21.70% <11.55%> (-41.15%) ⬇️
.-pkg-app-pipedv1-plugin-kubernetes 62.30% <ø> (ø)
.-pkg-app-pipedv1-plugin-kubernetes_multicluster 67.48% <ø> (ø)
.-pkg-app-pipedv1-plugin-scriptrun 54.83% <ø> (ø)
.-pkg-app-pipedv1-plugin-terraform 38.31% <ø> (ø)
.-pkg-app-pipedv1-plugin-wait 35.51% <ø> (ø)
.-pkg-app-pipedv1-plugin-waitapproval 68.62% <ø> (ø)
.-pkg-plugin-sdk 50.45% <ø> (ø)
.-tool-actions-gh-release 19.23% <ø> (ø)
.-tool-actions-plan-preview 25.30% <ø> (ø)
.-tool-codegen-protoc-gen-auth 0.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

…n/analysis/config-stage-app

Signed-off-by: t-kikuc <tkikuchi07f@gmail.com>
Copy link
Copy Markdown
Member

@khanhtc1202 khanhtc1202 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

Copy link
Copy Markdown
Member

@ffjlabo ffjlabo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@t-kikuc t-kikuc merged commit 53c9873 into master Aug 28, 2025
46 of 48 checks passed
@t-kikuc t-kikuc deleted the plugin/analysis/config-stage-app branch August 28, 2025 00:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants