Skip to content

[Analysis Plugin] Import analysisprovider from pipedv0#6155

Merged
t-kikuc merged 7 commits into
masterfrom
plugin/analysis/2-import-analyis-provider
Aug 28, 2025
Merged

[Analysis Plugin] Import analysisprovider from pipedv0#6155
t-kikuc merged 7 commits into
masterfrom
plugin/analysis/2-import-analyis-provider

Conversation

@t-kikuc
Copy link
Copy Markdown
Member

@t-kikuc t-kikuc commented Aug 25, 2025

What this PR does:

  • Copied the analysisprovider package from pipedv0 to pipedv1

Why we need it:

  • to support Analysis in the same way as pipedv0

Which issue(s) this PR fixes:

Part of #6068
Follows #6153

Does this PR introduce a user-facing change?:

  • How are users affected by this change:
  • Is this breaking change:
  • How to migrate (if breaking change):

@t-kikuc t-kikuc requested a review from a team as a code owner August 25, 2025 08:58
@t-kikuc t-kikuc marked this pull request as draft August 25, 2025 08:58
@t-kikuc
Copy link
Copy Markdown
Member Author

t-kikuc commented Aug 25, 2025

Ready for review after merging #6153

@codecov
Copy link
Copy Markdown

codecov Bot commented Aug 25, 2025

Codecov Report

❌ Patch coverage is 28.79257% with 230 lines in your changes missing coverage. Please review.
✅ Project coverage is 28.57%. Comparing base (53c9873) to head (ad86fae).
⚠️ Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
.../analysisprovider/metrics/prometheus/prometheus.go 40.77% 53 Missing and 8 partials ⚠️
...alysis/analysisprovider/metrics/factory/factory.go 0.00% 56 Missing ⚠️
...alysis/analysisprovider/metrics/datadog/datadog.go 54.11% 36 Missing and 3 partials ⚠️
...edv1/plugin/analysis/analysisprovider/http/http.go 0.00% 34 Missing ⚠️
...ugin/analysis/analysisprovider/metrics/provider.go 0.00% 17 Missing ⚠️
...n/analysis/analysisprovider/log/factory/factory.go 0.00% 15 Missing ⚠️
...is/analysisprovider/log/stackdriver/stackdriver.go 0.00% 8 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##           master    #6155    +/-   ##
========================================
  Coverage   28.56%   28.57%            
========================================
  Files         540      548     +8     
  Lines       57722    58045   +323     
========================================
+ Hits        16491    16586    +95     
- Misses      39949    40165   +216     
- Partials     1282     1294    +12     
Flag Coverage Δ
. 23.25% <ø> (+0.01%) ⬆️
.-pkg-app-pipedv1-plugin-analysis 25.49% <28.79%> (+3.78%) ⬆️
.-pkg-app-pipedv1-plugin-kubernetes 60.24% <ø> (ø)
.-pkg-app-pipedv1-plugin-kubernetes_multicluster 67.48% <ø> (ø)
.-pkg-app-pipedv1-plugin-scriptrun 54.83% <ø> (ø)
.-pkg-app-pipedv1-plugin-terraform 38.31% <ø> (ø)
.-pkg-app-pipedv1-plugin-wait 35.51% <ø> (ø)
.-pkg-app-pipedv1-plugin-waitapproval 68.62% <ø> (ø)
.-pkg-plugin-sdk 50.17% <ø> (-0.20%) ⬇️
.-tool-actions-gh-release 19.23% <ø> (ø)
.-tool-actions-plan-preview 25.30% <ø> (ø)
.-tool-codegen-protoc-gen-auth 0.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@t-kikuc t-kikuc mentioned this pull request Aug 25, 2025
8 tasks
Signed-off-by: t-kikuc <tkikuchi07f@gmail.com>
Signed-off-by: t-kikuc <tkikuchi07f@gmail.com>
Signed-off-by: t-kikuc <tkikuchi07f@gmail.com>
Signed-off-by: t-kikuc <tkikuchi07f@gmail.com>
Signed-off-by: t-kikuc <tkikuchi07f@gmail.com>
Signed-off-by: t-kikuc <tkikuchi07f@gmail.com>
Signed-off-by: t-kikuc <tkikuchi07f@gmail.com>
@t-kikuc t-kikuc force-pushed the plugin/analysis/2-import-analyis-provider branch from d90a5a7 to ad86fae Compare August 28, 2025 03:32
@t-kikuc t-kikuc marked this pull request as ready for review August 28, 2025 03:37
@t-kikuc t-kikuc enabled auto-merge (squash) August 28, 2025 03:37
Copy link
Copy Markdown
Member

@khanhtc1202 khanhtc1202 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks 🙏

Copy link
Copy Markdown
Member

@Warashi Warashi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@t-kikuc t-kikuc merged commit 0dd7586 into master Aug 28, 2025
45 checks passed
@t-kikuc t-kikuc deleted the plugin/analysis/2-import-analyis-provider branch August 28, 2025 05:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants