Skip to content

Implement with initializer to sdk#6158

Merged
ffjlabo merged 2 commits into
masterfrom
implement-WithInitializer-to-sdk
Aug 25, 2025
Merged

Implement with initializer to sdk#6158
ffjlabo merged 2 commits into
masterfrom
implement-WithInitializer-to-sdk

Conversation

@ffjlabo
Copy link
Copy Markdown
Member

@ffjlabo ffjlabo commented Aug 25, 2025

What this PR does:

Add WithInitializer to SDK.

Why we need it:

Which issue(s) this PR fixes:

Part of #5530

Does this PR introduce a user-facing change?:

  • How are users affected by this change:
  • Is this breaking change:
  • How to migrate (if breaking change):

Signed-off-by: Yoshiki Fujikane <ffjlabo@gmail.com>
Signed-off-by: Yoshiki Fujikane <ffjlabo@gmail.com>
@ffjlabo ffjlabo requested a review from a team as a code owner August 25, 2025 11:44
@github-actions github-actions Bot added area/go area/plugin-sdk piped-plugin-sdk labels Aug 25, 2025
Copy link
Copy Markdown
Member

@khanhtc1202 khanhtc1202 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

Copy link
Copy Markdown
Member

@Warashi Warashi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@ffjlabo ffjlabo enabled auto-merge (squash) August 25, 2025 11:45
@codecov
Copy link
Copy Markdown

codecov Bot commented Aug 25, 2025

Codecov Report

❌ Patch coverage is 0% with 21 lines in your changes missing coverage. Please review.
✅ Project coverage is 28.67%. Comparing base (45a82f7) to head (884a534).
⚠️ Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
pkg/plugin/sdk/plugin.go 0.00% 21 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6158      +/-   ##
==========================================
- Coverage   28.68%   28.67%   -0.02%     
==========================================
  Files         534      534              
  Lines       57328    57349      +21     
==========================================
  Hits        16442    16442              
- Misses      39608    39629      +21     
  Partials     1278     1278              
Flag Coverage Δ
. 23.28% <ø> (ø)
.-pkg-app-pipedv1-plugin-analysis 62.85% <ø> (ø)
.-pkg-app-pipedv1-plugin-kubernetes 62.30% <ø> (ø)
.-pkg-app-pipedv1-plugin-kubernetes_multicluster 67.48% <ø> (ø)
.-pkg-app-pipedv1-plugin-scriptrun 54.83% <ø> (ø)
.-pkg-app-pipedv1-plugin-terraform 38.31% <ø> (ø)
.-pkg-app-pipedv1-plugin-wait 35.51% <ø> (ø)
.-pkg-app-pipedv1-plugin-waitapproval 68.62% <ø> (ø)
.-pkg-plugin-sdk 50.45% <0.00%> (-0.54%) ⬇️
.-tool-actions-gh-release 19.23% <ø> (ø)
.-tool-actions-plan-preview 25.30% <ø> (ø)
.-tool-codegen-protoc-gen-auth 0.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ffjlabo ffjlabo merged commit 2595b9d into master Aug 25, 2025
44 of 48 checks passed
@ffjlabo ffjlabo deleted the implement-WithInitializer-to-sdk branch August 25, 2025 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants