Skip to content

[k8s plugin] Implement helm registry login#6161

Merged
ffjlabo merged 6 commits into
masterfrom
implement-helm-registry-login
Aug 25, 2025
Merged

[k8s plugin] Implement helm registry login#6161
ffjlabo merged 6 commits into
masterfrom
implement-helm-registry-login

Conversation

@ffjlabo
Copy link
Copy Markdown
Member

@ffjlabo ffjlabo commented Aug 25, 2025

What this PR does:

Implement the feature to login to the OCI helm registry.

Why we need it:

We want to support the feature to use remote helm chart.

Which issue(s) this PR fixes:

Part of #5764
Follow #6158

Does this PR introduce a user-facing change?:

  • How are users affected by this change:
  • Is this breaking change:
  • How to migrate (if breaking change):

Signed-off-by: Yoshiki Fujikane <ffjlabo@gmail.com>
Signed-off-by: Yoshiki Fujikane <ffjlabo@gmail.com>
Signed-off-by: Yoshiki Fujikane <ffjlabo@gmail.com>
Signed-off-by: Yoshiki Fujikane <ffjlabo@gmail.com>
@codecov
Copy link
Copy Markdown

codecov Bot commented Aug 25, 2025

Codecov Report

❌ Patch coverage is 7.14286% with 52 lines in your changes missing coverage. Please review.
✅ Project coverage is 28.46%. Comparing base (006c8aa) to head (29be599).
⚠️ Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
pkg/app/pipedv1/plugin/kubernetes/main.go 0.00% 23 Missing ⚠️
pkg/app/pipedv1/plugin/kubernetes/provider/helm.go 4.54% 21 Missing ⚠️
...app/pipedv1/plugin/kubernetes/deployment/plugin.go 20.00% 4 Missing ⚠️
pkg/app/pipedv1/plugin/kubernetes/config/plugin.go 0.00% 2 Missing ⚠️
.../app/pipedv1/plugin/kubernetes/livestate/plugin.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6161      +/-   ##
==========================================
- Coverage   28.67%   28.46%   -0.21%     
==========================================
  Files         534      532       -2     
  Lines       57346    56982     -364     
==========================================
- Hits        16442    16220     -222     
+ Misses      39626    39506     -120     
+ Partials     1278     1256      -22     
Flag Coverage Δ
. 23.14% <ø> (-0.15%) ⬇️
.-pkg-app-pipedv1-plugin-analysis 62.85% <ø> (ø)
.-pkg-app-pipedv1-plugin-kubernetes 61.50% <7.14%> (-0.81%) ⬇️
.-pkg-app-pipedv1-plugin-kubernetes_multicluster 67.48% <ø> (ø)
.-pkg-app-pipedv1-plugin-scriptrun ?
.-pkg-app-pipedv1-plugin-terraform 38.31% <ø> (ø)
.-pkg-app-pipedv1-plugin-wait 35.51% <ø> (ø)
.-pkg-app-pipedv1-plugin-waitapproval 68.62% <ø> (ø)
.-pkg-plugin-sdk 50.45% <ø> (ø)
.-tool-actions-gh-release 19.23% <ø> (ø)
.-tool-actions-plan-preview 25.30% <ø> (ø)
.-tool-codegen-protoc-gen-auth 0.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

khanhtc1202
khanhtc1202 previously approved these changes Aug 25, 2025
Copy link
Copy Markdown
Member

@khanhtc1202 khanhtc1202 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

Signed-off-by: Yoshiki Fujikane <ffjlabo@gmail.com>
Signed-off-by: Yoshiki Fujikane <ffjlabo@gmail.com>
Copy link
Copy Markdown
Member

@khanhtc1202 khanhtc1202 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

Copy link
Copy Markdown
Member

@Warashi Warashi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🆗

@ffjlabo ffjlabo merged commit f27919d into master Aug 25, 2025
48 of 51 checks passed
@ffjlabo ffjlabo deleted the implement-helm-registry-login branch August 25, 2025 23:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants