Skip to content

[SDK] Fix nil pointer plugin config#6164

Merged
ffjlabo merged 1 commit into
masterfrom
fix-nil-pointer-plugin-config
Aug 26, 2025
Merged

[SDK] Fix nil pointer plugin config#6164
ffjlabo merged 1 commit into
masterfrom
fix-nil-pointer-plugin-config

Conversation

@ffjlabo
Copy link
Copy Markdown
Member

@ffjlabo ffjlabo commented Aug 26, 2025

What this PR does:

Allow users not to set plugin config in the piped config.

Why we need it:

Which issue(s) this PR fixes:

Part of #5530
Follow #6161

Does this PR introduce a user-facing change?:

  • How are users affected by this change:
  • Is this breaking change:
  • How to migrate (if breaking change):

Signed-off-by: Yoshiki Fujikane <ffjlabo@gmail.com>
@ffjlabo ffjlabo requested a review from a team as a code owner August 26, 2025 01:18
@github-actions github-actions Bot added area/go area/plugin-sdk piped-plugin-sdk labels Aug 26, 2025
@ffjlabo ffjlabo changed the title Fix nil pointer plugin config [SDK] Fix nil pointer plugin config Aug 26, 2025
Copy link
Copy Markdown
Member

@Warashi Warashi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

@codecov
Copy link
Copy Markdown

codecov Bot commented Aug 26, 2025

Codecov Report

❌ Patch coverage is 0% with 9 lines in your changes missing coverage. Please review.
✅ Project coverage is 28.56%. Comparing base (04c196a) to head (143689d).
⚠️ Report is 3 commits behind head on master.

Files with missing lines Patch % Lines
pkg/plugin/sdk/plugin.go 0.00% 9 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6164      +/-   ##
==========================================
- Coverage   28.59%   28.56%   -0.03%     
==========================================
  Files         535      535              
  Lines       57242    57288      +46     
==========================================
  Hits        16367    16367              
- Misses      39603    39649      +46     
  Partials     1272     1272              
Flag Coverage Δ
. 23.13% <ø> (ø)
.-pkg-app-pipedv1-plugin-analysis 62.85% <ø> (ø)
.-pkg-app-pipedv1-plugin-kubernetes 60.91% <ø> (-0.68%) ⬇️
.-pkg-app-pipedv1-plugin-kubernetes_multicluster 67.48% <ø> (ø)
.-pkg-app-pipedv1-plugin-scriptrun 54.83% <ø> (ø)
.-pkg-app-pipedv1-plugin-terraform 38.31% <ø> (ø)
.-pkg-app-pipedv1-plugin-wait 35.51% <ø> (ø)
.-pkg-app-pipedv1-plugin-waitapproval 68.62% <ø> (ø)
.-pkg-plugin-sdk 50.24% <0.00%> (-0.13%) ⬇️
.-tool-actions-gh-release 19.23% <ø> (ø)
.-tool-actions-plan-preview 25.30% <ø> (ø)
.-tool-codegen-protoc-gen-auth 0.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ffjlabo ffjlabo enabled auto-merge (squash) August 26, 2025 01:20
@ffjlabo ffjlabo merged commit 1a0e3c2 into master Aug 26, 2025
43 of 48 checks passed
@ffjlabo ffjlabo deleted the fix-nil-pointer-plugin-config branch August 26, 2025 01:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants