Skip to content

Update helm repo when chart is not found#6169

Merged
ffjlabo merged 1 commit into
masterfrom
update-helm-repo-after-deploy
Aug 26, 2025
Merged

Update helm repo when chart is not found#6169
ffjlabo merged 1 commit into
masterfrom
update-helm-repo-after-deploy

Conversation

@ffjlabo
Copy link
Copy Markdown
Member

@ffjlabo ffjlabo commented Aug 26, 2025

What this PR does:

as title

This is the TODO in the prev PR #6162

Why we need it:

Which issue(s) this PR fixes:

Part of #5764
Follow #6162

Does this PR introduce a user-facing change?:

  • How are users affected by this change:
  • Is this breaking change:
  • How to migrate (if breaking change):

Signed-off-by: Yoshiki Fujikane <ffjlabo@gmail.com>
@ffjlabo ffjlabo requested a review from a team as a code owner August 26, 2025 02:57
@ffjlabo ffjlabo enabled auto-merge (squash) August 26, 2025 02:58
Copy link
Copy Markdown
Member

@Warashi Warashi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

@codecov
Copy link
Copy Markdown

codecov Bot commented Aug 26, 2025

Codecov Report

❌ Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 28.55%. Comparing base (1f22063) to head (299c896).
⚠️ Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
pkg/app/pipedv1/plugin/kubernetes/provider/helm.go 0.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6169      +/-   ##
==========================================
- Coverage   28.57%   28.55%   -0.02%     
==========================================
  Files         535      535              
  Lines       57285    57289       +4     
==========================================
- Hits        16367    16361       -6     
- Misses      39647    39657      +10     
  Partials     1271     1271              
Flag Coverage Δ
. 23.12% <ø> (-0.02%) ⬇️
.-pkg-app-pipedv1-plugin-analysis 62.85% <ø> (ø)
.-pkg-app-pipedv1-plugin-kubernetes 60.84% <0.00%> (-0.07%) ⬇️
.-pkg-app-pipedv1-plugin-kubernetes_multicluster 67.48% <ø> (ø)
.-pkg-app-pipedv1-plugin-scriptrun 54.83% <ø> (ø)
.-pkg-app-pipedv1-plugin-terraform 38.31% <ø> (ø)
.-pkg-app-pipedv1-plugin-wait 35.51% <ø> (ø)
.-pkg-app-pipedv1-plugin-waitapproval 68.62% <ø> (ø)
.-pkg-plugin-sdk 50.32% <ø> (ø)
.-tool-actions-gh-release 19.23% <ø> (ø)
.-tool-actions-plan-preview 25.30% <ø> (ø)
.-tool-codegen-protoc-gen-auth 0.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Copy Markdown
Member

@khanhtc1202 khanhtc1202 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

@ffjlabo ffjlabo merged commit 9866567 into master Aug 26, 2025
46 of 48 checks passed
@ffjlabo ffjlabo deleted the update-helm-repo-after-deploy branch August 26, 2025 03:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants