Skip to content

[k8s plugin] Implement template helm remote chart for pipedv1#6162

Merged
khanhtc1202 merged 3 commits into
masterfrom
implement-template-helm-remote-chart-for-pipedv1
Aug 26, 2025
Merged

[k8s plugin] Implement template helm remote chart for pipedv1#6162
khanhtc1202 merged 3 commits into
masterfrom
implement-template-helm-remote-chart-for-pipedv1

Conversation

@ffjlabo
Copy link
Copy Markdown
Member

@ffjlabo ffjlabo commented Aug 26, 2025

What this PR does:

Implemented the feature to deploy helm remote chart.
TODO: update repo after templating

Why we need it:

We want to support deploying helm remote chart.

Which issue(s) this PR fixes:

Part of #5764
Follow #6161

Does this PR introduce a user-facing change?:

  • How are users affected by this change:
  • Is this breaking change:
  • How to migrate (if breaking change):

@ffjlabo ffjlabo requested a review from a team as a code owner August 26, 2025 00:12
@ffjlabo ffjlabo changed the title Implement template helm remote chart for pipedv1 [k8s plugin] Implement template helm remote chart for pipedv1 Aug 26, 2025
@codecov
Copy link
Copy Markdown

codecov Bot commented Aug 26, 2025

Codecov Report

❌ Patch coverage is 63.76812% with 25 lines in your changes missing coverage. Please review.
✅ Project coverage is 28.56%. Comparing base (f27919d) to head (9473dd6).
⚠️ Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
pkg/app/pipedv1/plugin/kubernetes/provider/helm.go 60.31% 18 Missing and 7 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6162      +/-   ##
==========================================
+ Coverage   28.55%   28.56%   +0.01%     
==========================================
  Files         535      528       -7     
  Lines       57168    57094      -74     
==========================================
- Hits        16322    16307      -15     
+ Misses      39581    39515      -66     
- Partials     1265     1272       +7     
Flag Coverage Δ
. 23.14% <ø> (ø)
.-pkg-app-pipedv1-plugin-analysis ?
.-pkg-app-pipedv1-plugin-kubernetes 61.58% <63.76%> (+0.08%) ⬆️
.-pkg-app-pipedv1-plugin-kubernetes_multicluster 67.48% <ø> (ø)
.-pkg-app-pipedv1-plugin-scriptrun 54.83% <ø> (ø)
.-pkg-app-pipedv1-plugin-terraform 38.31% <ø> (ø)
.-pkg-app-pipedv1-plugin-wait ?
.-pkg-app-pipedv1-plugin-waitapproval 68.62% <ø> (ø)
.-pkg-plugin-sdk 50.45% <ø> (ø)
.-tool-actions-gh-release 19.23% <ø> (ø)
.-tool-actions-plan-preview 25.30% <ø> (ø)
.-tool-codegen-protoc-gen-auth 0.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Signed-off-by: Yoshiki Fujikane <ffjlabo@gmail.com>
Signed-off-by: Yoshiki Fujikane <ffjlabo@gmail.com>
Signed-off-by: Yoshiki Fujikane <ffjlabo@gmail.com>
@ffjlabo ffjlabo force-pushed the implement-template-helm-remote-chart-for-pipedv1 branch from 7289544 to 9473dd6 Compare August 26, 2025 00:18
Copy link
Copy Markdown
Member

@khanhtc1202 khanhtc1202 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

Copy link
Copy Markdown
Member

@Warashi Warashi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

@khanhtc1202 khanhtc1202 merged commit e73f85d into master Aug 26, 2025
48 checks passed
@khanhtc1202 khanhtc1202 deleted the implement-template-helm-remote-chart-for-pipedv1 branch August 26, 2025 00:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants