Add helm chart workflow for pipedv1 exp#6200
Merged
Merged
Conversation
Signed-off-by: khanhtc1202 <khanhtc1202@gmail.com>
Signed-off-by: khanhtc1202 <khanhtc1202@gmail.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #6200 +/- ##
==========================================
- Coverage 28.80% 28.79% -0.02%
==========================================
Files 559 559
Lines 59568 59568
==========================================
- Hits 17160 17154 -6
- Misses 41094 41100 +6
Partials 1314 1314
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
|
About the diff between diff --ignore-all-space --color=always --recursive manifests/piped manifests/pipedv1-exp
diff -u --ignore-all-space --color=always --recursive manifests/piped/Chart.yaml manifests/pipedv1-exp/Chart.yaml
--- manifests/piped/Chart.yaml 2024-06-11 13:31:52
+++ manifests/pipedv1-exp/Chart.yaml 2025-09-03 14:44:14
@@ -1,6 +1,6 @@
apiVersion: v2
-name: piped
-description: A Helm chart for Piped
+name: pipedv1-exp
+description: A Helm chart for Pipedv1 Experimental
# A chart can be either an 'application' or a 'library' chart.
# Application charts are a collection of templates that can be packaged into versioned archives
diff -u --ignore-all-space --color=always --recursive manifests/piped/templates/NOTES.txt manifests/pipedv1-exp/templates/NOTES.txt
--- manifests/piped/templates/NOTES.txt 2024-06-11 13:31:52
+++ manifests/pipedv1-exp/templates/NOTES.txt 2025-09-03 14:44:14
@@ -1 +1 @@
-Now, the installed piped is connecting to {{ .Values.args.address }}.
+Check config map for piped configuration, which provides ControlPlane connecting information.
diff -u --ignore-all-space --color=always --recursive manifests/piped/templates/_helpers.tpl manifests/pipedv1-exp/templates/_helpers.tpl
--- manifests/piped/templates/_helpers.tpl 2025-04-07 15:23:15
+++ manifests/pipedv1-exp/templates/_helpers.tpl 2025-09-03 14:44:14
@@ -152,7 +152,6 @@
- --config-file=/etc/piped-config/{{ .Values.config.fileName }}
{{- end }}
- --metrics={{ .Values.args.metrics }}
-- --enable-default-kubernetes-cloud-provider={{ .Values.args.enableDefaultKubernetesCloudProvider }}
- --log-encoding={{ .Values.args.logEncoding }}
- --log-level={{ .Values.args.logLevel }}
- --add-login-user-to-passwd={{ .Values.args.addLoginUserToPasswd }}
@@ -170,11 +169,9 @@
- piped
- --config-file=/etc/piped-config/{{ .Values.config.fileName }}
- --metrics={{ .Values.args.metrics }}
-- --enable-default-kubernetes-cloud-provider={{ .Values.args.enableDefaultKubernetesCloudProvider }}
- --log-encoding={{ .Values.args.logEncoding }}
- --log-level={{ .Values.args.logLevel }}
- --add-login-user-to-passwd={{ .Values.args.addLoginUserToPasswd }}
-- --app-manifest-cache-count={{ .Values.args.appManifestCacheCount }}
{{- if .Values.quickstart.enabled }}
- --insecure=true
{{- else }}
diff -u --ignore-all-space --color=always --recursive manifests/piped/values.yaml manifests/pipedv1-exp/values.yaml
--- manifests/piped/values.yaml 2025-04-07 15:23:15
+++ manifests/pipedv1-exp/values.yaml 2025-09-03 14:44:14
@@ -1,11 +1,10 @@
image:
- repository: ghcr.io/pipe-cd/piped
+ repository: ghcr.io/pipe-cd/pipedv1-exp
# Overrides the image tag whose default is the chart appVersion.
tag: ""
args:
metrics: true
- enableDefaultKubernetesCloudProvider: true
insecure: false
# One of "humanize", "json", or "console" is available.
logEncoding: humanize
@@ -16,9 +15,8 @@
addLoginUserToPasswd: false
# Ensure that the pod will be restarted by random an annotation value to key rollme.
forceRestart: true
- # The number of app manifests to cache. The cache-key contains the commit hash. The default is 150. (default 150)
- appManifestCacheCount: 150
+# TODO: Support launcher
launcher:
enabled: false
image: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does:
SSIA
Why we need it:
This makes pipedv1-exp testing easier for users.
Local tested using the following commands:
$ make build/chart MOD=pipedv1-exp VERSION=v1.0.0-rc0 $ helm template pipedv1-exp .artifacts/pipedv1-exp-v1.0.0-rc0.tgz --version=v1.0.0-rc0 --namespace=pipecd --create-namespace --set-file config.data=.dev/pipedv1-config.yaml --set-file secret.data.ssh-key=xxx > OUT.yamlWhich issue(s) this PR fixes:
Part of #4980
Does this PR introduce a user-facing change?: