Refine local environment commands in makefile#6216
Merged
Conversation
Signed-off-by: khanhtc1202 <khanhtc1202@gmail.com>
Member
Author
|
@linhdangduy PTAL when you have time 👀 |
khanhtc1202
commented
Sep 12, 2025
| kind delete cluster --name pipecd | ||
|
|
||
| .PHONY: down/local-registry | ||
| down/local-registry: |
Member
Author
There was a problem hiding this comment.
Better to separate this from down/kind-cluster to keep the built container images on local.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #6216 +/- ##
==========================================
+ Coverage 28.77% 28.90% +0.12%
==========================================
Files 559 546 -13
Lines 59526 57887 -1639
==========================================
- Hits 17131 16732 -399
+ Misses 41081 39878 -1203
+ Partials 1314 1277 -37
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
t-kikuc
approved these changes
Sep 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does:
ssia
Why we need it:
Which issue(s) this PR fixes:
Follow PR #6131
Does this PR introduce a user-facing change?: