Skip to content

Refine local environment commands in makefile #6216

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
khanhtc1202 merged 1 commit into from
Sep 12, 2025
Merged

Refine local environment commands in makefile #6216

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 13 additions & 4 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,8 @@
# gen: execute code or docs generation
# release: commands used in release flow
# push: push artifacts such as helm chart
# up: prepare local environment (registry, kind cluster)
# down: shutdown/cleanup local environment (registry, kind cluster)
####################

# Build commands
Expand Down Expand Up @@ -277,8 +279,7 @@ release/pick:
release/docs:
./hack/gen-release-docs.sh $(version)

# Other commands

# Local environment commands
.PHONY: up/local-registry
up/local-registry:
./hack/create-local-registry.sh
Expand All @@ -290,11 +291,19 @@ up/kind-cluster:
.PHONY: up/local-cluster
up/local-cluster: up/local-registry up/kind-cluster

.PHONY: down/local-cluster
down/local-cluster:
.PHONY: down/kind-cluster
down/kind-cluster:
kind delete cluster --name pipecd

.PHONY: down/local-registry
down/local-registry:
Copy link
Copy Markdown
Member Author

@khanhtc1202 khanhtc1202 Sep 12, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Better to separate this from down/kind-cluster to keep the built container images on local.

docker container rm -f kind-registry 2>/dev/null

.PHONY: down/local-cluster
down/local-cluster: down/kind-cluster down/local-registry

# Other commands

.PHONY: setup-envtest
# Where to install the setup-envtest binary
setup-envtest: export GOBIN ?= ${PWD}/.dev/bin
Expand Down