fix: make lint/go for non-interactive environments

[Parship12]

What this PR does:
Fix make lint/go for non-interactive environments.

Why we need it:
make lint/go was failing in non-interactive environments (like ci or automated scripts) due to the -it flag in the docker command, which causing "the input device is not a TTY" error. The lint output is shown in the console, but the command returns a failure exit code.

Changes:

• Removed -it flag from lint/go.

Testing:

• make lint/go: complete with exit code 0
• 13 Go modules report 0 linting issues

Before:

After:

Note: CI workflow already has working golangci-lint integration with reviewdog and uses a matrix strategy for parallel execution, which is optimal for CI. This PR focuses on fixing local/scripted usage of make lint/go.

Does this PR introduce a user-facing change?: No

• How are users affected by this change: This change only affects developers running make lint/go locally or in scripts.
• Is this breaking change: No
• How to migrate (if breaking change): NA

[eeshaanSA]

cc: @khanhtc1202 @Warashi

[Ayushmore1214]

Hey @Parship12, thanks for this! However, I'd suggest we revert the changes to lint.yaml the current setup uses a matrix to run linting in parallel (which is faster) and uses reviewdog to post comments directly on the code. If we switch to a single make lint/go command in CI, we lose that parallelism and the inline feedback, which makes debugging harder for contributors, So Let's keep the Makefile fix and kep the Github workflow as is , otherwise nice!

[Parship12]

Good point. I will revert the lint.yaml changes. Thanks

[Parship12]

While testing issue #4566, I discovered the -it flag issue (fixed in this PR). I believe #4566/#4566 (comment) can be closed as I think both the todos are done (make lint/go working with no errors and CI already has a better solution).

[Parship12]

@eeshaanSA @khanhtc1202 PTAL

[Ayushmore1214]

LGTM

[github-actions]

This PR is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 7 days.

[Warashi]

Sorry for late review, LGTM