Skip to content

First release candidate#54

Merged
waralex merged 10 commits into
devfrom
first_release_candidat
Aug 28, 2020
Merged

First release candidate#54
waralex merged 10 commits into
devfrom
first_release_candidat

Conversation

@waralex

@waralex waralex commented Aug 24, 2020

Copy link
Copy Markdown
Contributor

Candidate for first release with reverse dependencies

@waralex
waralex requested a review from alexcjohnson August 24, 2020 07:47
@github-actions github-actions Bot added documentation Improvements or additions to documentation enhancement New feature or request tests labels Aug 24, 2020
dashjl.wait_for_element_by_css_selector(
"#a"
)
"#a", timeout=4

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All these extra timeouts are awkward - we already wait for the server to report it's accessible and then wait for the page to have some dash content - is there something else we need to wait for after those two?

Not an issue to be solved in this repo, the fix needs to be in dash.testing, just curious if you have any insight about what's going on.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alexcjohnson In fact, here we are waiting for the first callback (i.e. _dash_update_component) to be executed. Since the Julia is JIT compiler, the corresponding code is compiled at this moment. After the release, I plan to do optimization on this side - see where I can more accurately define the types and add the ability to precompile when installing the package.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK cool - I suspect it'll be relatively important to get this right for the developer experience, but fine to omit for now. Is there an issue for this in which we can mention the goal to remove all these extra test timeouts?

Comment thread README.md Outdated
Comment thread README.md
Comment thread src/Front.jl Outdated
Co-authored-by: Alex Johnson <johnson.alex.c@gmail.com>

@alexcjohnson alexcjohnson left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💃 🥇 🚀

@waralex
waralex merged commit c3d6a17 into dev Aug 28, 2020
@etpinard
etpinard deleted the first_release_candidat branch June 13, 2023 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation enhancement New feature or request tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants