-
-
Notifications
You must be signed in to change notification settings - Fork 45
First release candidate #54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
dc4deb1
reverse dependency
waralex c976cb6
ci+readme changes
waralex c5fd554
compat
waralex d7f0e2e
add DashBase to ci and readme
waralex 767637e
increase timeout
waralex 93a2f49
increase test timeouts
waralex e01ee49
Update src/Front.jl
waralex 1cfaf4a
change components repos to plotly
waralex 9c6a26b
Merge branch 'first_release_candidat' of https://github.com/plotly/Da…
waralex b031aa7
Merge branch 'dev' into first_release_candidat
waralex File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,17 +1,4 @@ | ||
| module Front | ||
| import JSON, JSON2, PlotlyBase | ||
|
|
||
|
|
||
| to_dash(t::Any) = t | ||
| from_dash(::Type{Any}, t::Any) = t | ||
|
|
||
|
|
||
| function from_dash(::Type{PlotlyBase.Plot}, t) | ||
| data = PlotlyBase.GenericTrace[PlotlyBase.GenericTrace(tr) for tr in t.data] | ||
| layout = PlotlyBase.Layout(t.layout) | ||
| PlotlyBase.Plot(data, layout) | ||
| end | ||
|
|
||
| #FIXME It's not elegant, but I didn't find elegant solution | ||
| JSON2.write(io::IO, p::PlotlyBase.Plot; kwargs...) = write(io, JSON.json(p)) | ||
| end |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.