Skip to content
This repository was archived by the owner on Aug 29, 2025. It is now read-only.

Save cell on tab#122

Merged
valentijnnieman merged 3 commits into
masterfrom
107-save-on-tab
Oct 3, 2018
Merged

Save cell on tab#122
valentijnnieman merged 3 commits into
masterfrom
107-save-on-tab

Conversation

@valentijnnieman

Copy link
Copy Markdown
Contributor

Closes #107. This saves data when selecting a cell, changing the value, and pressing the 'tab' key.

@Marc-Andre-Rivet

Marc-Andre-Rivet commented Oct 2, 2018

Copy link
Copy Markdown
Contributor

Looks good to me. Once merged, please create a follow up PR to merge into develop.

@cldougl

cldougl commented Oct 2, 2018

Copy link
Copy Markdown
Member

It looks like the deployed examples: https://dash-table-review-pr-122.herokuapp.com/editor-with-configurable-options have some weird editing behavior now:
You should be able to click and edit where clicking but I can only append edit:
click

still investigating if this is related to changes here or broke somewhere else

@Marc-Andre-Rivet

Marc-Andre-Rivet commented Oct 2, 2018

Copy link
Copy Markdown
Contributor

@cldougl Interesting.. fwiw, I'm not seeing this behavior when running either 107-* or master locally. Due to the nature of the change, it seems highly unlikely that it would have triggered this behavior

@cldougl

cldougl commented Oct 2, 2018

Copy link
Copy Markdown
Member

I'm not seeing it on the frontend example (ie npm run build.watch) but I am on the editor-with-configurable-options python example both deployed on heroku and locally
anyway I'm seeing it on master as well.

@valentijnnieman

Copy link
Copy Markdown
Contributor Author

Hmm that's strange. If it's an issue that happens in Python but not JS then the problem would probably lie in the props updating between Dash and React (setProps etc) somewhere. But my changes shouldn't really have affected those, I feel!

@cldougl

cldougl commented Oct 3, 2018

Copy link
Copy Markdown
Member

@valentijnnieman yep your changes don't affect- it's on master too ( 💃 from me on this and I'll cont the investigation on the above issue :) )

@valentijnnieman

Copy link
Copy Markdown
Contributor Author

Hmm, any suggestions on how to fix the ci/circleci: visual-test? It seems stuck!

@Marc-Andre-Rivet

Copy link
Copy Markdown
Contributor

@valentijnnieman changed the settings for the master branch.. visual-test does not exist there yet :) You should be able to squash/merge now

@valentijnnieman
valentijnnieman merged commit 0af48b8 into master Oct 3, 2018
@chriddyp
chriddyp temporarily deployed to dash-table-review-pr-126 October 3, 2018 18:39 Inactive
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants