This repository was archived by the owner on Aug 29, 2025. It is now read-only.
107 save on tab -> develop#126
Merged
Merged
Conversation
| }); | ||
|
|
||
| // https://github.com/plotly/dash-table/issues/107 | ||
| it.only('can edit last and update dataframe on "tab"', () => { |
Contributor
There was a problem hiding this comment.
Guessing I missed it in master too? It only impacts local test watch, not the cypress run so it's not too bad :)
Contributor
|
@valentijnnieman Once you fix the .only above, this looks good to me |
Contributor
|
@valentijnnieman looks good, fire away |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@Marc-Andre-Rivet Here's the follow-up PR to merge into develop, as you suggested in #122