This repository was archived by the owner on Aug 29, 2025. It is now read-only.
Refactor table API #446
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -40,7 +40,7 @@ class App extends Component { | |
| className='clear-filters' | ||
| onClick={() => { | ||
| const tableProps = R.clone(this.state.tableProps); | ||
| tableProps.filter_query = ''; | ||
|
|
||
| this.setState({ tableProps }); | ||
| }} | ||
|
|
@@ -53,7 +53,7 @@ class App extends Component { | |
| } | ||
| onBlur={e => { | ||
| const tableProps = R.clone(this.state.tableProps); | ||
| tableProps.filter_query = e.target.value; | ||
|
|
||
| this.setState({ tableProps }); | ||
| }} /> | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -4,12 +4,12 @@ import Environment from 'core/environment'; | |
|
|
||
| import { generateMockData, IDataMock, generateSpaceMockData } from './data'; | ||
| import { | ||
| PropsWithDefaults, | ||
| ChangeAction, | ||
| ChangeFailure, | ||
| IVisibleColumn, | ||
| ColumnType, | ||
| TableAction | ||
| } from 'dash-table/components/Table/props'; | ||
| import { TooltipSyntax } from 'dash-table/tooltips/props'; | ||
|
|
||
|
|
@@ -46,19 +46,19 @@ function getBaseTableProps(mock: IDataMock) { | |
| on_change: { | ||
| action: ChangeAction.None | ||
| }, | ||
| renamable: true, | ||
| deletable: true | ||
| })), | ||
| dropdown: { | ||
| bbb: { | ||
| clearable: true, | ||
| options: ['Humid', 'Wet', 'Snowy', 'Tropical Beaches'].map(i => ({ | ||
| label: i, | ||
| value: i | ||
| })) | ||
| } | ||
| }, | ||
| page_action: TableAction.None, | ||
| style_table: { | ||
| max_height: '800px', | ||
| height: '800px', | ||
|
|
@@ -77,24 +77,23 @@ function getBaseTableProps(mock: IDataMock) { | |
| function getDefaultState( | ||
| generateData: Function = generateMockData | ||
| ): { | ||
| filter_query: string, | ||
| tableProps: Partial<PropsWithDefaults> | ||
| } { | ||
| const mock = generateData(5000); | ||
|
|
||
| return { | ||
| filter_query: '', | ||
| tableProps: R.merge(getBaseTableProps(mock), { | ||
| data: mock.data, | ||
| editable: true, | ||
| sort_action: TableAction.Native, | ||
| fixed_rows: { headers: true }, | ||
| fixed_columns: { headers: true }, | ||
| merge_duplicate_headers: false, | ||
| row_deletable: true, | ||
| row_selectable: 'single', | ||
| page_action: TableAction.Native | ||
| }) as Partial<PropsWithDefaults> | ||
| }; | ||
| } | ||
|
|
@@ -113,16 +112,16 @@ function getReadonlyState() { | |
|
|
||
| function getSpaceInColumn() { | ||
| const state = getDefaultState(generateSpaceMockData); | ||
| state.tableProps.filter_action = TableAction.Native; | ||
|
|
||
| return state; | ||
| } | ||
|
|
||
| function getFixedTooltipsState() { | ||
| const state = getTooltipsState(); | ||
|
|
||
| state.tableProps.fixed_columns = { headers: true, data: 1 }; | ||
| state.tableProps.fixed_rows = { headers: true, data: 1 }; | ||
|
|
||
| return state; | ||
| } | ||
|
|
@@ -132,25 +131,23 @@ function getTooltipsState() { | |
|
|
||
| state.tableProps.tooltip_delay = 250; | ||
| state.tableProps.tooltip_duration = 1000; | ||
| state.tableProps.tooltip_data = [ | ||
| { ccc: { type: TooltipSyntax.Markdown, value: `### Go Proverb\nThe enemy's key point is yours` } }, | ||
| { ccc: { type: TooltipSyntax.Markdown, value: `### Go Proverb\nPlay on the point of symmetry` } }, | ||
| { ccc: { type: TooltipSyntax.Markdown, value: `### Go Proverb\nSente gains nothing` } }, | ||
| { ccc: { type: TooltipSyntax.Text, value: `Beware of going back to patch up` } }, | ||
| { ccc: { type: TooltipSyntax.Text, value: `When in doubt, Tenuki` } }, | ||
| { ccc: `People in glass houses should not throw stones` } | ||
| ]; | ||
| state.tableProps.tooltip = { | ||
| ccc: { type: TooltipSyntax.Text, value: `There is death in the hane` }, | ||
| ddd: { type: TooltipSyntax.Markdown, value: `Hane, Cut, Placement` }, | ||
| rows: `Learn the eyestealing tesuji` | ||
| }; | ||
| state.tableProps.tooltip_conditional = [{ | ||
| if: { | ||
| column_id: 'aaa-readonly', | ||
| filter_query: `{aaa} is prime` | ||
| }, | ||
| type: TooltipSyntax.Markdown, | ||
| value: `### Go Proverbs\nCapture three to get an eye` | ||
|
|
@@ -218,7 +215,7 @@ function getDateState() { | |
|
|
||
| function getFilteringState() { | ||
| const state = getDefaultState(); | ||
| state.tableProps.filter_action = TableAction.Native; | ||
|
|
||
| return state; | ||
| } | ||
|
|
@@ -227,15 +224,14 @@ function getVirtualizedState() { | |
| const mock = generateMockData(5000); | ||
|
|
||
| return { | ||
| filter_query: '', | ||
| tableProps: R.merge(getBaseTableProps(mock), { | ||
| data: mock.data, | ||
| editable: true, | ||
| sort_action: TableAction.Native, | ||
| merge_duplicate_headers: false, | ||
| row_deletable: true, | ||
| row_selectable: 'single', | ||
| virtualization: true | ||
| }) | ||
| }; | ||
|
|
@@ -245,17 +241,16 @@ function getFixedVirtualizedState() { | |
| const mock = generateMockData(5000); | ||
|
|
||
| return { | ||
| filter_query: '', | ||
| tableProps: R.merge(getBaseTableProps(mock), { | ||
| data: mock.data, | ||
| editable: true, | ||
| sort_action: TableAction.Native, | ||
| fixed_rows: { headers: true }, | ||
| fixed_columns: { headers: true }, | ||
| merge_duplicate_headers: false, | ||
| row_deletable: true, | ||
| row_selectable: 'single', | ||
| virtualization: true | ||
| }) | ||
| }; | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -58,7 +58,6 @@ export const generateMockData = (rows: number) => unpackIntoColumnsAndData([ | |
| name: ['', 'Weather', 'Climate'], | ||
| type: ColumnType.Text, | ||
| presentation: 'dropdown', | ||
| data: gendata( | ||
| i => ['Humid', 'Wet', 'Snowy', 'Tropical Beaches'][i % 4], | ||
| rows | ||
|
|
@@ -141,7 +140,6 @@ export const generateSpaceMockData = (rows: number) => unpackIntoColumnsAndData( | |
| name: ['', 'Weather', 'Climate'], | ||
| type: ColumnType.Text, | ||
| presentation: 'dropdown', | ||
| data: gendata( | ||
| i => ['Humid', 'Wet', 'Snowy', 'Tropical Beaches'][i % 4], | ||
| rows | ||
|
|
@@ -162,11 +160,6 @@ export const mockDataSimple = (rows: number) => unpackIntoColumnsAndData([ | |
| name: 'Climate', | ||
| type: ColumnType.Text, | ||
| presentation: 'dropdown', | ||
| data: gendata( | ||
| i => ['Humid', 'Wet', 'Snowy', 'Tropical Beaches'][i % 4], | ||
| rows | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -302,7 +302,7 @@ camels.forEach(([camel]) => map.set(camel, camel)); | |
|
|
||
| const fs = require('fs'); | ||
|
|
||
| var stream1 = fs.createWriteStream('src/dash-table/derived/style/py2jsCssProperties.ts'); | ||
| stream1.once('open', () => { | ||
| stream1.write('export type StyleProperty = string | number;\n'); | ||
| stream1.write('\n'); | ||
|
|
@@ -317,25 +317,25 @@ stream1.once('open', () => { | |
| first = false; | ||
| stream1.write(` ['${key}', '${value}']`); | ||
| }); | ||
| stream1.write('\n]);'); | ||
|
|
||
| stream1.end(); | ||
| }); | ||
|
|
||
| var stream2 = fs.createWriteStream('src/dash-table/derived/style/IStyle.ts'); | ||
| stream2.once('open', () => { | ||
| stream2.write(`import { StyleProperty } from './ py2jsCssProperties';\n`); | ||
| stream2.write('\n'); | ||
| stream2.write('export default interface IStyle {\n'); | ||
| camels.forEach(([key]) => { | ||
| stream2.write(` ${key}: StyleProperty;\n`); | ||
| }); | ||
| stream2.write('}'); | ||
|
|
||
| stream2.end(); | ||
| }); | ||
|
|
||
| var stream3 = fs.createWriteStream('proptypes.js'); | ||
| stream3.once('open', () => { | ||
| let first = true; | ||
| map.forEach((value, key) => { | ||
|
|
@@ -350,7 +350,7 @@ stream3.once('open', () => { | |
| stream3.write(` ${key}: PropTypes.oneOfType([PropTypes.string, PropTypes.number])`); | ||
| } | ||
| }); | ||
| stream3.write('\n'); | ||
|
|
||
| stream3.end(); | ||
| }); | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.