Skip to content
This repository was archived by the owner on Aug 29, 2025. It is now read-only.

Refactor table API#446

Merged
Marc-Andre-Rivet merged 55 commits into
masterfrom
core-issue-58-refactor-api
Jun 7, 2019
Merged

Refactor table API#446
Marc-Andre-Rivet merged 55 commits into
masterfrom
core-issue-58-refactor-api

Conversation

@Marc-Andre-Rivet

@Marc-Andre-Rivet Marc-Andre-Rivet commented May 28, 2019

Copy link
Copy Markdown
Contributor

Fixes https://github.com/plotly/dash-core/issues/58

See https://github.com/plotly/dash-core/issues/58#issuecomment-496593455 for detailed entries.

  • update prop types documentation
  • update changelog

Marc-André Rivet and others added 2 commits May 28, 2019 16:32
- editable_name -> renamable
- deletable & renamable: bool|number -> bool|bool[]
- remove options
@chriddyp
chriddyp temporarily deployed to dash-table-review-pr-446 May 28, 2019 20:34 Inactive
@chriddyp
chriddyp temporarily deployed to dash-table-review-pr-446 May 29, 2019 00:55 Inactive
@chriddyp
chriddyp temporarily deployed to dash-table-review-pr-446 May 29, 2019 01:17 Inactive
@chriddyp
chriddyp temporarily deployed to dash-table-review-pr-446 May 29, 2019 01:41 Inactive
@chriddyp
chriddyp temporarily deployed to dash-table-review-pr-446 May 29, 2019 14:38 Inactive
@chriddyp
chriddyp temporarily deployed to dash-table-review-pr-446 May 29, 2019 15:01 Inactive
@chriddyp
chriddyp temporarily deployed to dash-table-review-pr-446 May 29, 2019 15:57 Inactive
Marc-André Rivet added 2 commits May 29, 2019 12:02
@chriddyp
chriddyp temporarily deployed to dash-table-review-pr-446 May 29, 2019 16:04 Inactive
@chriddyp
chriddyp temporarily deployed to dash-table-review-pr-446 May 29, 2019 16:10 Inactive
- column_dropdown_data `objectOf`
- update usages and tests
@chriddyp
chriddyp temporarily deployed to dash-table-review-pr-446 May 29, 2019 16:32 Inactive
@chriddyp
chriddyp temporarily deployed to dash-table-review-pr-446 May 29, 2019 16:42 Inactive
@chriddyp
chriddyp temporarily deployed to dash-table-review-pr-446 May 29, 2019 17:03 Inactive
@chriddyp
chriddyp temporarily deployed to dash-table-review-pr-446 May 29, 2019 18:29 Inactive
@chriddyp
chriddyp temporarily deployed to dash-table-review-pr-446 May 29, 2019 18:33 Inactive
@chriddyp
chriddyp temporarily deployed to dash-table-review-pr-446 June 7, 2019 16:21 Inactive
@chriddyp
chriddyp temporarily deployed to dash-table-review-pr-446 June 7, 2019 16:22 Inactive
Comment thread CHANGELOG.md
Renamed `sort_mode`.
- `derived_filter_structure`
Renamed to `derived_filter_query_structure`.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- `'fe'` renamed to `'native'`
- `'be'` renamed to `'custom'`

Comment thread CHANGELOG.md
Comment thread CHANGELOG.md Outdated
Comment thread src/dash-table/dash/DataTable.js Outdated
Comment thread src/dash-table/dash/DataTable.js Outdated
Comment thread src/dash-table/dash/DataTable.js Outdated
Co-Authored-By: Chris Parmer <chris@plot.ly>
@chriddyp
chriddyp temporarily deployed to dash-table-review-pr-446 June 7, 2019 16:42 Inactive
@chriddyp
chriddyp temporarily deployed to dash-table-review-pr-446 June 7, 2019 16:46 Inactive
Co-Authored-By: Chris Parmer <chris@plot.ly>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants