This repository was archived by the owner on Aug 29, 2025. It is now read-only.
Refactor API - remove column.hidden#473
Merged
Merged
Conversation
Marc-Andre-Rivet
marked this pull request as ready for review
June 18, 2019 22:13
| { name: ['City', 'Montreal'], id: 'montreal' }, | ||
| { name: ['City', 'Toronto'], id: 'toronto' }, | ||
| { name: ['City', 'Ottawa'], id: 'ottawa', hidden: true }, | ||
| { name: ['City', 'Ottawa'], id: 'ottawa' }, |
Contributor
Author
There was a problem hiding this comment.
This test is still interesting w/o the hidden nested prop. Keeping it!
alexcjohnson
approved these changes
Jun 18, 2019
alexcjohnson
left a comment
alexcjohnson
left a comment
Collaborator
There was a problem hiding this comment.
+4 / -95 what's not to like! 🔪 🔪 🔪
Good catch 💃
Marc-Andre-Rivet
added
dash-stage-in_progress
dash-stage-in_review
and removed
dash-stage-in_progress
labels
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overlooked as part of #446. Removing
column.hiddennested prop -- will be reworked / added back under a different guise with #314Removing or modifying the affected tests (base on whether the test is specifically about hiding); keeping the inner mechanic intact for the 314 changes to come which will require it again.