[Feature Request] dash.testing.browser should allow custom timeout on wait_for_page()

[iynehz]

While wait_for_page() the function itself is possible to take a timeout parameter, looks like when it's called in dash.testing.browser it is now always 10 sec for selenium to wait for dash app to serve.

dash/dash/testing/browser.py

Line 602 in 597dc22

self.wait_for_page()

dash/dash/testing/browser.py

Line 335 in 597dc22

def wait_for_page(self, url=None, timeout=10):

At our workplace we have some "heavy" setups on our dash apps. And I get error when trying out dash.testing like wait_for_page(347): dash server is not loaded within 10 seconds...

[alexcjohnson]

Ah, and I presume you're using dash_duo.start_server(app) which then throws an error on timeout, so you can't simply add another wait after that.

Looks like we should have wait_for_page work like the other wait_for_* methods, that set default timeout=None and then use it like timeout if timeout else self._wait_timeout

Then you'd be able to set dash_duo._wait_timeout to whatever you want, prior to calling start_server - though I notice we bake the timeout set on __init__ into _wd_wait and use it in _wait_for - let's just get rid of _wd_wait, I can't imagine a command that's specifically designed to wait caring about the cost of creating a new WebDriverWait object...

[iynehz]

@alexcjohnson Thanks for the comment. I didn't go to _wd_wait that level of details, but your understanding of my issue is exact. I was thinking you can change to use self._wait_timeout at this place

dash/dash/testing/browser.py

Line 602 in 597dc22

self.wait_for_page()

But your idea of changing wait_for_page looks better.

[amirhessam88]

is there any update on this ? I am hitting the same error

dash.testing.browser:browser.py:395 dash server is not loaded within 10 seconds