Skip to content

Testing improvements#2417

Merged
T4rk1n merged 8 commits into
devfrom
testing-improvments
Feb 14, 2023
Merged

Testing improvements#2417
T4rk1n merged 8 commits into
devfrom
testing-improvments

Conversation

@T4rk1n

@T4rk1n T4rk1n commented Feb 8, 2023

Copy link
Copy Markdown
Contributor

@T4rk1n
T4rk1n requested a review from alexcjohnson as a code owner February 8, 2023 14:19
@T4rk1n
T4rk1n force-pushed the testing-improvments branch from 1786843 to 7a6ac6a Compare February 8, 2023 19:31
@T4rk1n
T4rk1n force-pushed the testing-improvments branch from 7a6ac6a to 799d981 Compare February 8, 2023 19:56
with pytest.raises(TimeoutException) as err:
dash_duo.wait_for_text_to_equal("#none", "None", timeout=1.0)

assert err.value.args[0] == "text -> None not found within 1.0s, #none not found"

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh man, I've been thinking we should have useful error messages like this for a long time, thanks!

Comment thread dash/testing/plugin.py
Comment thread dash/dash.py

@alexcjohnson alexcjohnson left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💃

@T4rk1n
T4rk1n merged commit 6b27856 into dev Feb 14, 2023
@T4rk1n
T4rk1n deleted the testing-improvments branch February 14, 2023 14:05
@RonnyPfannschmidt

Copy link
Copy Markdown

this breaks as hookwrapeprs are expectedto yield, and rightfuly so
see pytest-dev/pytest#10820

@RonnyPfannschmidt

Copy link
Copy Markdown

ah, already fixed via #2461 and reported in #2460

lovely 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

3 participants