Conversation
alexcjohnson
approved these changes
Mar 16, 2023
alexcjohnson
left a comment
alexcjohnson
left a comment
Collaborator
There was a problem hiding this comment.
💃 Seems like it would be pretty annoying to write a test for this, I guess we just rely on the community to tell us about that 🤠
|
it may be reasonably simply to combine the pytester plugin plus a monkeypatch 🤞 |
Merged
Contributor
Author
Maybe a ci container that install just dash without testing and a very simple test to pass. |
Collaborator
|
Sure. If you think that's going to take time we can merge as is, release a patch, and add that test later. |
T4rk1n
force-pushed
the
fix-2460
branch
2 times, most recently
from
March 17, 2023 13:23
0f2e441 to
5b8ec5e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #2460