Skip to content

issue #1160 fix#1161

Closed
adamborowski wants to merge 1 commit into
plotly:masterfrom
adamborowski:patch-1
Closed

issue #1160 fix#1161
adamborowski wants to merge 1 commit into
plotly:masterfrom
adamborowski:patch-1

Conversation

@adamborowski

@adamborowski adamborowski commented Nov 17, 2016

Copy link
Copy Markdown
Contributor

If we play with timestamps, we have to leave range bounds integers

If we play with timestamps, we have to leave range bounds integers
@etpinard

Copy link
Copy Markdown
Contributor

Thanks for submitting a PR!

Looking like your patch unfortunately breaks zoom for non-date axes.

I'll look for a better solution. This bug is most likely a side-effect of #1078

@adamborowski

Copy link
Copy Markdown
Contributor Author

Yes, we can check if ax.type === 'date' then round the range

@etpinard

Copy link
Copy Markdown
Contributor

@adamborowski @alexcjohnson I think 683d38a would be the most robust way to fix this issue.

@adamborowski to make sure your work is rewarded, I'll apply the above commit on top of your d7de2ae commit, add a few tests and make another PR. Thanks very much for your efforts 🍻

@etpinard

Copy link
Copy Markdown
Contributor

replaced by #1162

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants