Skip to content

Modebar date zoom fix#1162

Merged
etpinard merged 5 commits into
masterfrom
modebar-date-zoom-fix
Nov 17, 2016
Merged

Modebar date zoom fix#1162
etpinard merged 5 commits into
masterfrom
modebar-date-zoom-fix

Conversation

@etpinard

Copy link
Copy Markdown
Contributor

adamborowski and others added 3 commits November 17, 2016 15:25
If we play with timestamps, we have to leave range bounds integers
- so that zoomed ranges are computed consistently
  for all axis types
@etpinard etpinard added status: reviewable bug something broken labels Nov 17, 2016
@etpinard etpinard mentioned this pull request Nov 17, 2016
- so that date axis ranges can be tested with some tolerance
@etpinard
etpinard force-pushed the modebar-date-zoom-fix branch from 1c44171 to c45338d Compare November 17, 2016 17:07
@alexcjohnson

Copy link
Copy Markdown
Collaborator

Beautiful. Nice cleanup of the tests. 💃

- looks like the CI machine has less precision
  than my laptop
@etpinard
etpinard merged commit 4d9b02d into master Nov 17, 2016
@etpinard
etpinard deleted the modebar-date-zoom-fix branch November 17, 2016 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug something broken

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Zoom in/out buttons don't work for time series

3 participants