installer: split required vs optional binaries - #2
Open
amd-mkarvir wants to merge 2 commits into
Open
Conversation
Closes the install regression where a missing rocm-codex binary in the release tarball caused install.sh to abort before placing anything in INSTALL_DIR. rocm and rocmd are now required; rocm-codex and engine plugins are optional and emit a warning when missing.
Author
|
@powderluv could you take a look when you have a chance? Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Splits the installer's binary check into required vs optional sets so that a bundle missing a non-essential binary (such as
rocm-codex) no longer aborts the install.Also clarifies in the README that
rocm-codexis optional rather than implying it ships in every bundle.Motivation
Currently the installer requires all four binaries (
rocm,rocmd,rocm-engine-pytorch,rocm-codex) to be present in the release tarball. If any is missing, the installer fails with no files installed.Recent release tarballs have shipped without
rocm-codex(documented as experimental). This blocks new users from installing the CLI at all even though the corerocm/rocmdfunctionality is fully present in the bundle.Reproduced on a fresh MI300X devcloud node
$ curl -fsSL https://raw.githubusercontent.com/powderluv/rocm-cli/main/install.sh | sh
rocm-cli installer
repo: powderluv/rocm-cli
channel: release
...
rocm-cli installer: bundle did not contain bin/rocm-codex
$ rocm doctor
Command 'rocm' not found
Same outcome with the
nightlychannel.Change
install.sh:REQUIRED_BINS="rocm rocmd"— installer fails fast if either is missingOPTIONAL_BINS="rocm-engine-pytorch rocm-codex"— installer warns to stderr if missing but proceeds${bundle_dir}/bin/*, so no behavior change for present binariesREADME.md:rocm-codexis optionalRationale for the split
rocm— the user-facing CLI entry point. Required.rocmd— the supervisor daemon. Required (managed services, automations, MCP server all depend on it).rocm-engine-pytorch— first-party serving engine. Useful but not required to runrocm doctor,rocm install, or non-serving flows.rocm-codex— TUI, marked experimental in code. Codex TUI is opt-in.Testing Done
Verified end-to-end on a fresh MI300X devcloud node