Skip to content

installer: split required vs optional binaries #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
amd-mkarvir wants to merge 2 commits into
base: main
Choose a base branch
from
Open

installer: split required vs optional binaries #2

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1c429cc
installer: split required vs optional binaries
amd-mkarvir Jun 1, 2026
744260a
docs: clarify rocm-codex is optional in repo status
amd-mkarvir Jun 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ Current repository status:
- `rocmd` supervisor with managed service supervision and persisted automation/watcher runtime state
- first-party `pytorch` engine with managed venv installs, TheRock PyTorch wheel resolution, and OpenAI-compatible local serving
- TheRock SDK resolver for `pip` and tarball installs, plus managed runtime update checks
- vendored Codex TUI scaffold with a packaged `rocm-codex` binary for experimental interactive launch
- vendored Codex TUI scaffold launched via `rocm --experimental-codex-tui` when the optional `rocm-codex` binary is present

Planned product shape:
- `rocm` chat-first TUI with deeper inline tool execution and approvals
Expand Down
19 changes: 15 additions & 4 deletions install.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -224,10 +224,21 @@ tar -xzf "$archive_path" -C "$extract_dir"
bundle_dir="$(find "$extract_dir" -mindepth 1 -maxdepth 1 -type d | head -n1)"
[ -n "$bundle_dir" ] || fail "unable to locate extracted bundle directory"

[ -f "${bundle_dir}/bin/rocm" ] || fail "bundle did not contain bin/rocm"
[ -f "${bundle_dir}/bin/rocmd" ] || fail "bundle did not contain bin/rocmd"
[ -f "${bundle_dir}/bin/rocm-engine-pytorch" ] || fail "bundle did not contain bin/rocm-engine-pytorch"
[ -f "${bundle_dir}/bin/rocm-codex" ] || fail "bundle did not contain bin/rocm-codex"
# Required binaries — the CLI cannot function without these.
REQUIRED_BINS="rocm rocmd"
# Optional binaries — desirable but not load-bearing. Missing ones produce a
# warning so the install succeeds with reduced functionality rather than
# failing entirely (e.g. a release bundle missing rocm-codex should still
# install the working CLI).
OPTIONAL_BINS="rocm-engine-pytorch rocm-codex"

for bin_name in $REQUIRED_BINS; do
[ -f "${bundle_dir}/bin/${bin_name}" ] || fail "bundle did not contain required binary bin/${bin_name}"
done

for bin_name in $OPTIONAL_BINS; do
[ -f "${bundle_dir}/bin/${bin_name}" ] || echo "rocm-cli installer: warning: bundle missing optional binary bin/${bin_name}" >&2
done

mkdir -p "$INSTALL_DIR"

Expand Down